Closed Bug 1858395 Opened 7 months ago Closed 7 months ago

Filelink attachment filenames not encoded

Categories

(Thunderbird :: FileLink, defect)

Product:
Thunderbird
Component:
FileLink
Type:
defect

Tracking

(thunderbird_esr115 fixed, thunderbird119 wontfix)

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
thunderbird_esr115 --- fixed
thunderbird119 --- wontfix

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Whiteboard: [TM 115.4.1])

Attachments

(1 file)

Bug 1858395 - Filelink attachment filename parameter should be encoded if needed. r=john.bieling
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta-
wsmwk
: approval-comm-esr115+
Details | Review

Filelink attachment filenames are not getting sent encoded. They should, as otherwise sending maybe rejected (and other incompatibilities) like bug 1830941 comment 7.

https://searchfox.org/comm-central/rev/68b0c093535c24e9a7d3acf6354d9eb8246895ce/mailnews/compose/src/MimeMessage.jsm#425

See Also: → 1830941
Status: NEW → ASSIGNED
status-thunderbird119: --- → affected
status-thunderbird_esr115: --- → affected
Keywords: checkin-needed-tb
Target Milestone: --- → 120 Branch

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/e04179407004
Filelink attachment filename parameter should be encoded if needed. r=john.bieling

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

There's a test failure in mailnews/compose/test/unit/test_messageHeaders.js since this landed.

Flags: needinfo?(mkmelin+mozilla)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7f701ac056ab
follow-up, fix test expectations. rs=bustage-fix DONTBUILD
Flags: needinfo?(mkmelin+mozilla)

Comment on attachment 9357885 [details]
Bug 1858395 - Filelink attachment filename parameter should be encoded if needed. r=john.bieling

[Approval Request Comment]
User impact if declined: filelink attachments might not get delivered
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Attachment #9357885 - Flags: approval-comm-esr115?
Attachment #9357885 - Flags: approval-comm-beta?
status-thunderbird119: affected → wontfix
Whiteboard: [TM 115.4.1]

Comment on attachment 9357885 [details]
Bug 1858395 - Filelink attachment filename parameter should be encoded if needed. r=john.bieling

[Triage Comment]
no more betas in this cycle, so target 115.4.1

Attachment #9357885 - Flags: approval-comm-beta? → approval-comm-beta-

Comment on attachment 9357885 [details]
Bug 1858395 - Filelink attachment filename parameter should be encoded if needed. r=john.bieling

[Triage Comment]
Approved for esr115

Attachment #9357885 - Flags: approval-comm-esr115? → approval-comm-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: