1858909 - Show ads in review checker Setting option is no longer displayed if the Review checker is turned off while checking a product until the product is checked on that page

Status: NEW

(Firefox :: Shopping, defect, P5)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: more_to_consider.gif

Found in

• 120.0a1 (2023-10-12)

Affected versions

• 120.0a1 (2023-10-12)

Tested platforms

• Affected platforms: Windows 11, macOS 12
• Unaffected platforms: none

Preconditions

• browser.shopping.experience2023.enabled: true
• browser.shopping.experience2023.optedIn: 1
• browser.shopping.experience2023.ads.enabled: true
• browser.shopping.experience2023.ads.userEnabled: true

Steps to reproduce

1. Open an Amazon product that needs to be analyzed and has the More to consider card displayed.
2. Click to analyze the product and Turn off review checker from settings.
3. Open the review checker and opt-in.

Expected result

• On Firefox 119: The Show ads in review checker is displayed as disabled and enabled automatically showing the more to consider card after the checking is completed.

Actual result

• The Show ads in the review checker option is not displayed in the Settings card only after the checking is completed.

Regression

• It seems that this changed with bug 1851246 per mozregression (https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b3cfd41c58abae895ac658247166ef8c6a555da5&tochange=f5b27964c6131977bd3bad9a98bdb43fea55cb99)

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:kpatenio, since you are the author of the regressor, bug 1851246, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[kpatenio]

Concerning Bug 1851246, one change to the settings component was the condition to render the ads toggle. Previously, we relied on a RPMGetBoolPref call to read the ad feature pref. But now we just read the pref value passed from shopping-container. Therefore it seems that the property adsEnabled is falsey when passed to the settings component in this case. We read the pref in the container here from two places in the sidebar child actor:

• clearing analysis details on the sidebar for a "non polled request" (searchfox), so something like refreshing the page and changing opt-in/opt-out state.
• after successfully fetching analysis details (searchfox). Ex. requesting a re-analysis

I suspect the cause of the issue to be:

• In the case where an analysis is in progress, when we detect a "non polled request" (like refreshing the page, changing opt-in/opt-out state), we update the sidebar to show the in progress message via this call.
• In doing so, we end up overwriting some data we had, such as adsEnabled and will cause it to be undefined once read in shopping-container in the _update function.

Another note:
This does not seem to be limited to opt-in and then opt-out. It occurs as well if you:

1. request re-analysis (stale analysis)
2. duplicate tab or refresh current page with analysis running
3. view settings; the toggle will still not be there

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1851246

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

adjusting P4 bugs to P5, as the P4 priority is reserved for the Web Platform Test bot