1858961 - ‘Recent Searches’ preference in about:preferences#search does not correspond the Figma design

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Attachment: Screenshot from 2023-10-13 16-15-46.png

Notes

• Per Figma design, the preference should be named ‘Show recent searches’.
• Per Figma design, the preference should be aligned with the rest.
• Screenshot attached.

Found in

• Nightly 120.0a1;

Affected versions

• Nightly 120.0a1;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Unaffected platforms

• N/A;

Preconditions

• browser.urlbar.recentsearches.featureGate set to true
• browser.urlbar.suggest.recentsearches set to true

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Go to about:preferences#search and look for ‘Recent Searches’ option, in the Search Suggestions section.
3. Observe the name.

Expected result

• Per Figma, the preference should be names 'Show recent searches’.
• Per Figma, the preference should be aligned with the rest.

Actual result

• Preference is named ‘Recent Searches’.
• Preference is misaligned.

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey Dale,

Looks like this entry in about:preferences got added in bug 1852848. Are there plans to update the string and layout here, or is the Figma out of date?

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1858961 - Update label for recent searches pref. r=flod

Comment 4

[Dale Harvey (:daleharvey)]

Yeh the string needs updated here, it was likely in flux.

I checked in with UX and agreed that the alignment here is good, they arent indented in the spec, the indendation for the items above are to signify those options are sub options relating to the privacy implications of sending the users searches / characters to the engine. Recent Searches are seperate from that as they work on local history.

Also these preferences are being worked on and the alignment is getting removed anyway

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 1858961 - Update recent search label in preferences. r=flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6c77cadfd26
Update recent search label in preferences. r=flod,fluent-reviewers,settings-reviewers,Gijs

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e6c77cadfd26

Comment 8

[Ardelean Oana, Desktop QA [:oardelean]]

Issue is verified as fixed on Nightly 121.0a1 and Firefox 120.0b2 on Windows 10, Ubuntu 22, macOS 12.
String is now displayed as ‘Show recent searches’ in about:preferences#search.
For the alignment behavior, please see Comment 4.