1859785 - Same search terms across different engines are using the same moz_historyform (update)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Notes

• Follow-up from bug 1858978

Found in

• Nightly 120.0a1;

Affected versions

• Nightly 120.0a1;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Preconditions

• browser.urlbar.recentsearches.featureGate set to true
• browser.urlbar.suggest.recentsearches set to true

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Have a search done with default engine(A) for search_term any time. (e.g. in the past - let's say 2 months ago - below STR cover this scenario, or just recently - for more recent searches, the recent search order will get changed by same search done on different engine)
3. Focus the Address Bar and perform some searches(x,y,z) using the default search engine(A).
4. Focus the Address Bar and notice the Recent Searches.
5. Use search shortcut for any engine, but the default engineA - e.g. @engineB search_term
6. Focus the Address Bar and notice the Recent Searches.
7. Change default engine to the engineB, focus the Address Bar and notice the Recent Searches.

Expected result

• step 4 - Recent Search display x,y,z for engine(A)
• step6 - Recent Search display x,y,z for engine(A)
• step7 - Recent search display search_term for engine(B)

Actual result

• step 4 - Recent Search display x,y,z for engine(A)
• step6 - Recent Search display x,y,z, search_term for engine(A)
• step7 - Recent search display search_term for engine(B)

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:aflorinescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Adrian Florinescu [:aflorinescu]]

As discussed with :dharvey and :hmosety, this is not in scope for 120 experiment, hence will not be fixed for 120 version, marking as such for visibility.

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1859785 - Only show recent searches since last engine change. r=daisuke

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a57589d787
Only show recent searches since last engine change. r=daisuke

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e2a57589d787

Comment 7

[Adrian Florinescu [:aflorinescu]]

Attachment: recent.mp4

Hey Dale.
Can you please elaborate how this patch affects the functionality for Recent Searches? At first glance, seems like this bug isn't fixed yet(see recording), in addition now not having the historical recent searches done with other engines before the default engine switch.

Comment 8

[Dale Harvey (:daleharvey)]

Hey Adrian, answering here so its easier to look back on.

You are right, for this fix I was concentrating on the situation where the other searches were performed because the user had switched default engines, when the user performs searches with non default engines then it is still possible to have them in an unexpected order.

I will clone this one so we dont get confused about tracking the patch, fixing that situation may end up in a wontfix, its likely on the big side of a code fix for what is a minor issue, but but not certain about that so will reopen to reconsider.