1859137 - Multi Account container address bar button is too dark with Firefox dark theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[bbhtt]

Attachment: image.png

Steps:

1. Install Multi Account Containers extension from Mozilla
2. Switch Firefox to dark theme
3. See that the bookmark button is too dark (see image)

Previously it was white I think

Comment 1

[bbhtt]

$ mozregression --good 2023-10-12 --bad 2023-10-14

 8:20.68 INFO: Narrowed integration regression window from [055864c7, 4cd17f7d] (3 builds) to [055864c7, 518d9d15] (2 builds) (~1 steps left)
 8:20.68 INFO: No more integration revisions, bisection finished.
 8:20.68 INFO: Last good revision: 055864c76b58044394c7ebe5bdab6d538d29e62f
 8:20.68 INFO: First bad revision: 518d9d15677fd5f154216762af1d5867c17a90a8
 8:20.68 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=518d9d15677fd5f154216762af1d5867c17a90a8

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1858711, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1859137 - Update some selectors I missed after bug 1858711. r=#theme

These are the only ones. Whoops.

Ironically, I fixed the multi-account containers icons recently in
https://github.com/mozilla/multi-account-containers/pull/2584, but
that's still unreleased.

If we don't care about third-party pageactions we could remove this
hack once that's fixed tho...

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858711

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0867c427ddde
Update some selectors I missed after bug 1858711. r=desktop-theme-reviewers,dao

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0867c427ddde