1858711 - Some menus does not follow OS theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Takanori MATSUURA]

Steps to reproduce:

1. Start Firefox
2. Apply Fall Foggy Forest theme
3. Show App menu, Extensions menu, Fx account menu, or Tabs list menu

Expected result:
Background of menus follow OS theme.

Actual Result:
Background of menus does not follow OS theme.

Additional Information:
Context menus follow OS theme.

Regression range by mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=65a367e340b27cb67622b6650cb01bed4c844139&tochange=11fb2a6e434951fbef0791563a159cbbdd42f4c8

Comment 1

[Dão Gottwald [:dao]]

Could you please provide screenshots here and/or explain how exactly the current behavior is problematic? Thanks!

Comment 2

[Takanori MATSUURA]

Attachment: Screenshot

Screenshot on Win11 x64.
The problem occurs in the menu boxed in red.
Red one under Tabs menu (and in the URL bar) is generated by "Share Backported" extension.

I set OS theme to dark.
Before the fix of bug 1853188, the menu has white letters with black background which follows OS theme.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1853188

:emilio, since you are the author of the regressor, bug 1853188, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1858711 - Refactor lwtheme attributes to account for missing colors. r=dao!,#theme!

When a theme doesn't specify popup colors, it makes sense to follow the
system-preferred color scheme. Refactor theming attributes so that we
can distinguish this. Instead of a single [lwt-popup-brighttext], we get
lwt-popup="dark"/"light", and handle it appropriately.

Same for the other relevant attributes.

Refactor sidebar theming (which already did this tri-state thing via
lwt-sidebar and lwt-sidebar-brighttext) to do the same using a single
lwt-sidebar attribute, and update the docs.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/518d9d15677f
Refactor lwtheme attributes to account for missing colors. r=dao,desktop-theme-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9206f73c0e6e
Fix a test I missed.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/518d9d15677f
https://hg.mozilla.org/mozilla-central/rev/9206f73c0e6e

Comment 8

[Donal Meehan [:dmeehan]]

:emilio could you set a severity on this, should this ride the train with Fx120 or should we consider a a Fx119 dot release ride along?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

I think this should ride the trains, unless someone strongly objects.

Comment 10

[Monica Chiorean]

I was able to reproduce the issue on Win11 using FF build 119.0a1(2023-09-19).
Verified as fixed on Win11 using FF build 120.0b4 and 121.0a1(2023-10-31).