185937 - certain filter criteria (like "has attachment" and "is junk") don't work for pop mail, and should be hidden

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[(not reading, please use [e-mail] instead)]

certain filter criteria (like "has attachment" and "is junk") don't work for pop
mail, and should be hidden.

they are there because of the mail view code.

if we can't make them work (and I doubt it is even possible with some of them
the way our code works), we should hide them from filters, but show them in mail
views.

Comment 1

[Andrew Perry]

Didnt "IS JUNK" work until the filter logic was placed in priority to the Junk
Mail code?

But, there were problems with messages that were being MOVED during a filter
action ... they werent being labelled as Junk Mail ?

Comment 2

[Ninoschka Baca]

1. I'm not sure that the "As Attachment" item should be removed:

I created a POP filter to move messages with attachments to a specific folder.
When messages are retrieved we do not know whether a message has an attachment
so the message remains in the Inbox. Once it is selected then an attachment icon
appears so it appears that the filter is not working, which is true.

But it actually does serve a purpose. If I select Tools|Run Filters on Selected
Folder then it moves the messages with attachments to the appropriate folder. I
don't know how likely this will happen but someone might find it useful.
Wouldn't this be true for IMAP accounts as well?

2. The "is junk" item seems confusing to have it in the filters dialog when
there is a separate dialog for junk controls so I would agree to its removal.

Comment 3

[(not reading, please use [e-mail] instead)]

it can work for filter after the fact, but it doesn't work on incoming mail,
because we don't know if a message has an attachment until we open it, and we
don't know if a message is junk until we analyze it.  (there have been requests
to allow users to set the junk status as a filter action, but that's seperate
from filtering on it.)

I say "can work" because if I haven't opened a message or analysed it, we still
might not filter after the fact all messages that have attachments or are junk.

I'd rather not have it the filter UI if it doesn't always work as expected.

The places it does work would be search and mail views, so it should be visible
there.

ninosckha, what do you think about hiding it from the filter UI?

Comment 4

[Ninoschka Baca]

It's fine to hide it from the filter ui since it doesn't always work.

Comment 5

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 6

[(not reading, please use [e-mail] instead)]

over to nbaca, since this is view / search / filter related

Comment 7

[(not reading, please use [e-mail] instead)]

this UI change has a=jglick

Comment 8

[(not reading, please use [e-mail] instead)]

1.4 beta, I hope.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: fix, plus some code cleanup.

the fix is to define a new table for offline mail filters (pop and movemail
filters) that has the same items as the offline mail filters, except for junk
status and attachment status.

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Comment 11

[Ninoschka Baca]

Trunk build 2003-03-25: WinMe, Mac 10.1.5, Linux RH 8
Verified Fixed. Message filters for POP accounts no longer display "has
attachment" or "is junk" options. IMAP accounts still do not display this
criteria as well.

Comment 12

[(not reading, please use [e-mail] instead)]

*** Bug 183104 has been marked as a duplicate of this bug. ***