1859446 - More clean up in table code

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

+++ This bug was initially created as a clone of Bug #1857585 +++

The bug collects the cleanup patches written while I'm reading table fragmentation code. None of the patches changes behavior.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 1 - Remove haveRow variable in nsTableRowGroupFrame::ReflowChildren(). r?#layout

We don't need set haveRow to true in every iteration in the loop over table
rows. It is sufficient to check GetFirstRow().

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 2 - Remove TableRowGroupReflowInput::tableFrame. r?#layout

tableFrame is seldom used, and all the functions that need the table frame
have already got it via GetTableFrame() helper.

Depends on D191151

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 3 - Rename member vars in TableRowGroupReflowInput to match coding style. r?#layout

Also, remove using TableRowGroupReflowInput statement since it helps my editor
jump directly to TableRowGroupReflowInput's definition rather than to the
alias.

Depends on D191152

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 4 - Rename desiredSize variable for table row children. r?#layout

Add "kid" prefix for table row's desired size so that it won't be confused with
aDesiredSize output argument.

Depends on D191153

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 5 - Make CreateContinuingRowFrame() return newly created table row frame. r?#layout

Depends on D191154

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1859446 Part 6 - Remove unused nsresult return value from various table methods. r?#layout

We never communicate error status via the nsresult return value, and they
always return NS_OK. Hence the removal.

Depends on D191155

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1623646beb0c
Part 1 - Remove haveRow variable in nsTableRowGroupFrame::ReflowChildren(). r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/898884b9aa84
Part 2 - Remove TableRowGroupReflowInput::tableFrame. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/75054752f021
Part 3 - Rename member vars in TableRowGroupReflowInput to match coding style. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/7b5c9e93ed48
Part 4 - Rename desiredSize variable for table row children. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/823aec1de554
Part 5 - Make CreateContinuingRowFrame() return newly created table row frame. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/3ed0446401b6
Part 6 - Remove unused nsresult return value from various table methods. r=layout-reviewers,jfkthame

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1623646beb0c
https://hg.mozilla.org/mozilla-central/rev/898884b9aa84
https://hg.mozilla.org/mozilla-central/rev/75054752f021
https://hg.mozilla.org/mozilla-central/rev/7b5c9e93ed48
https://hg.mozilla.org/mozilla-central/rev/823aec1de554
https://hg.mozilla.org/mozilla-central/rev/3ed0446401b6