Closed Bug 1859752 Opened 1 year ago Closed 29 days ago

Update our in-tree ICU to 75

Categories

(Core :: Internationalization, enhancement)

Product:
Core
Component:
Internationalization
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1927706

People

(Reporter: anba, Assigned: anba)

References

(
URL
)

Details

(Keywords: perf-alert)

Attachments

(16 obsolete files)

Also updates to CLDR 44 and Unicode 15.1 and brings various bug fixes and improvements.

Release notes: https://icu.unicode.org/download/74

This is required to support CJK Ext.I characters.

See Also: → 1862182
Blocks: 1862601

Remove files for patches which have been integrated into upstream and add
new patch files to fix regressions in ICU 74.

Update patch file to apply cleanly on ICU 74.

Depends on D192708

Update language tag mappings by running ./make_intl_data.py langtags.

Updated by running ./make_intl_data.py numbering and ./make_intl_data.py units.

Depends on D192729

Updated by running ./make_unicode.py --version=UNIDATA.

Depends on D192731

Update by running genUnicodePropertyData.pl, genSpecialCasingData.pl, and cldr-quotes.pl.

Depends on D192732

Use CLASS_CHARACTER because that matches the previous character class for most
characters which are now part of the new character classes.

Depends on D192733

The currency display name for multiple locales is now only defined in the "root" locale,
which triggers the U_USING_DEFAULT_WARNING case, so we have to change our detection
when no localisation was found.

Depends on D192734

The fix for https://unicode-org.atlassian.net/browse/ICU-22547 only handled four
character long language subtags, but language subtags with more than four
characters are still handled incorrectly.

Depends on D192735

Rebuilt "special-case.cc" by running "gen-regexp-special-case.cc".

Drive-by change:

  • Remove unused files "property-sequences.{h,cc}" which include stale Unicode data.

Depends on D192736

Update results to match CLDR 44 resp. Unicode 15.1.

Depends on D192737

Update test results for CLDR 44.

Depends on D192738

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8b46595de6b5 Part 1: Add or remove ICU patch files. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/b191be0ec825 Part 2: Update ICU patch files. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/1e22b97c98ba Part 3: Update in-tree ICU to 74. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/e4495cec8e4b Part 4: Update language tag mappings. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/16b9813a9c61 Part 5: Update numbering and measurement units. r=spidermonkey-reviewers,mgaudet https://hg.mozilla.org/integration/autoland/rev/152860574068 Part 6: Update time zone mappings. r=spidermonkey-reviewers,mgaudet https://hg.mozilla.org/integration/autoland/rev/cbde31ce55a8 Part 7: Update SpiderMonkey to Unicode 15.1. r=spidermonkey-reviewers,mgaudet https://hg.mozilla.org/integration/autoland/rev/1e39572cb1c7 Part 8: Update Gecko to Unicode 15.1. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/0e7eefda2425 Part 9: Add new line break classes. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/a42248554021 Part 10: Adjust currency display name fallback handling. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/33d0d72d1abe Part 11: Add workarounds for ICU bugs. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/a2c6ae62fbf7 Part 12: Update irregexp special-casing. r=iain https://hg.mozilla.org/integration/autoland/rev/c5eca26f8dff Part 13: Update expected test results. r=spidermonkey-reviewers,mgaudet https://hg.mozilla.org/integration/autoland/rev/da94a164d4ea Part 14: Update expected test results for non-SpiderMonkey code. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/b5bf398e3069 Part 15: Bump minimum required ICU version to 74.1. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/35ff07f4726a Part 16: Updating ICU requires a clobber. r=platform-i18n-reviewers,dminor
Blocks: 1806348

Backed out 18 changesets (Bug 1863960, Bug 1859752) as requested in Bug 1864612 CLOSED TREE
Link: https://hg.mozilla.org/integration/autoland/rev/cb79861638fa94cb8c4df5b5e303dc4bd22f762c

Status: RESOLVED → REOPENED
status-firefox121: fixed → ---
Resolution: FIXED → ---
Target Milestone: 121 Branch → ---

(In reply to Noemi Erli[:noemi_erli] from comment #21)

Backed out 18 changesets (Bug 1863960, Bug 1859752) as requested in Bug 1864612 CLOSED TREE
Link: https://hg.mozilla.org/integration/autoland/rev/cb79861638fa94cb8c4df5b5e303dc4bd22f762c

== Change summary for alert #40248 (as of Wed, 15 Nov 2023 16:49:58 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
5% Base Content Explicit linux1804-64-shippable-qr fission 10,190,522.67 -> 9,732,453.33
4% Base Content Resident Unique Memory windows11-64-2009-shippable-qr fission 10,861,397.33 -> 10,374,314.67
4% Base Content Explicit windows11-64-2009-shippable-qr fission 10,988,389.33 -> 10,498,746.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40248

Duplicate of this bug: 1866662

We should either cherry-pick this commit or wait for ICU 74.2.

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:anba, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(mgaudet)
Flags: needinfo?(andrebargull)
Flags: needinfo?(mgaudet)
Flags: needinfo?(andrebargull)

ICU bug was fixed long ago. Chromium is working on updating to ICU 74.2. Do you have any plan to re-land this (with ICU updated to 74.2)?

Flags: needinfo?(andrebargull)
See Also: → https://issues.chromium.org/issues/40286402

Unless there's some immediate need to update to ICU74, for example due to web-compat bugs, I was actually planning to skip ICU74 and directly update to ICU75, which is scheduled to be released in less than a month.

Flags: needinfo?(andrebargull)
Summary: Update our in-tree ICU to 74 → Update our in-tree ICU to 75

ICU 75.1 was released on 2024-04-17.

Flags: needinfo?(andrebargull)

(In reply to Takanori MATSUURA from comment #29)

ICU 75.1 was released on 2024-04-17.

No worries, I didn't miss the update, but updating is currently blocked on https://unicode-org.atlassian.net/browse/ICU-22729.

Flags: needinfo?(andrebargull)
Blocks: 1909112

This bug have been superseded by bug 1927706.

Status: REOPENED → RESOLVED
Closed: 1 year ago → 29 days ago
Duplicate of bug: 1927706
Resolution: --- → DUPLICATE
Attachment #9361880 - Attachment is obsolete: true
Attachment #9361881 - Attachment is obsolete: true
Attachment #9361910 - Attachment is obsolete: true
Attachment #9361913 - Attachment is obsolete: true
Attachment #9361914 - Attachment is obsolete: true
Attachment #9361915 - Attachment is obsolete: true
Attachment #9361916 - Attachment is obsolete: true
Attachment #9361917 - Attachment is obsolete: true
Attachment #9361918 - Attachment is obsolete: true
Attachment #9361919 - Attachment is obsolete: true
Attachment #9361920 - Attachment is obsolete: true
Attachment #9361921 - Attachment is obsolete: true
Attachment #9361922 - Attachment is obsolete: true
Attachment #9361923 - Attachment is obsolete: true
Attachment #9361924 - Attachment is obsolete: true
Attachment #9361925 - Attachment is obsolete: true
No longer blocks: 1806348, 1862601, 1909112
See Also: 1862182 →
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: