Open
Bug 1860038
Opened 6 months ago
Updated 2 months ago
Enable network.dns.port_prefixed_qname_https_rr
Categories
(Core :: Networking: DNS, defect, P2)
Core
Networking: DNS
Tracking
()
People
(Reporter: valentin, Assigned: valentin)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [necko-triaged][necko-priority-next])
Comment 1•6 months ago
|
||
Set release status flags based on info from the regressing bug 1755902
:kershaw, since you are the author of the regressor, bug 1755902, could you take a look?
For more information, please visit BugBot documentation.
status-firefox118:
--- → affected
status-firefox119:
--- → affected
status-firefox120:
--- → affected
status-firefox-esr115:
--- → affected
Flags: needinfo?(kershaw)
Updated•6 months ago
|
Comment 2•6 months ago
|
||
Set release status flags based on info from the regressing bug 1755902
status-firefox121:
--- → affected
Assignee | ||
Comment 4•6 months ago
|
||
I was looking at writing a test for this and realized that this is actually preffed off.
We'll turn it on in this bug instead.
Assignee | ||
Updated•6 months ago
|
Flags: needinfo?(kershaw)
Assignee | ||
Comment 5•6 months ago
|
||
I later realized that we change the host to include the port, and that is being used for keying, so there's no issue with
if (StaticPrefs::network_dns_port_prefixed_qname_https_rr() &&
type == nsIDNSService::RESOLVE_TYPE_HTTPSSVC && aPort != -1 &&
aPort != 443) {
originHost = Some(host);
host = nsPrintfCString("_%d._https.%s", aPort, host.get());
LOG((" Using port prefixed host name [%s]", host.get()));
}
[...]
nsHostKey key(host, aTrrServer, type, flags, af,
(aOriginAttributes.mPrivateBrowsingId > 0), originSuffix);
Where I think there might be issues is when cancelling the request for example here we should also pass the port.
I'll keep this bug open to flip the pref and enable the feature.
Keywords: regression
No longer regressed by: 1755902
Summary: Port prefixed HTTPS resolutions are cached with the same key → Enable network.dns.port_prefixed_qname_https_rr
Assignee | ||
Updated•2 months ago
|
Blocks: necko-pref-flips
Assignee | ||
Updated•2 months ago
|
Whiteboard: [necko-triaged][necko-priority-review] → [necko-triaged][necko-priority-next]
You need to log in
before you can comment on or make changes to this bug.
Description
•