1860186 - Don't split strings for AABs

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Zac McKenney [:zmckenney]]

Because we have in-app language selection, for now we will package all strings and translations with the base app.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1860186 - Dont split languages in AAB (#4174)

Comment 2

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/cbbfdd7641b4e63399f853f75c0fdb93dd409340
[main] Bug 1860186 - Dont split languages in AAB

Comment 3

[Mira Lobontiu (Android QA)]

Verified on a Fenix Nightly build from AAB, with the following devices:

• Sony Xperia Z5 Premium (Android 7.1.1), and
• Oppo Find N2 Flip (Android 13).

Changing the app's language works as expected. All the menus are immediately translated, there is no need for Fenix to be closed.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1860186 - Dont split languages in AAB (backport #4174) (#4399)

Comment 5

[Zac McKenney [:zmckenney]]

Comment on attachment 9359479 [details] [review]
[mozilla-mobile/firefox-android] Bug 1860186 - Dont split languages in AAB (#4174)

Beta/Release Uplift Approval Request

• User impact if declined: Testing AAB in Beta for 120 won't be possible (due to language selector not working on AAB without this change) which will prevent moving to AAB in 120 release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Once Beta has this change uplifted AND an AAB build has been uploaded to the play store this can be tested. It will be the same process as before which is using the Settings > Language selector and confirming it works (it will either break for all other languages or work for all other languages).
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): bundle { } is only used when creating Android App Bundles so this is ignored for the current APK generation. Additionally, this just keeps strings together so this has no detrimental effects and is well documented here:
  https://developer.android.com/guide/app-bundle/configure-base#disable_config_apks
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Zac McKenney [:zmckenney]]

Comment on attachment 9362422 [details] [review]
[mozilla-mobile/firefox-android] Bug 1860186 - Dont split languages in AAB (backport #4174) (#4399)

Beta/Release Uplift Approval Request

• User impact if declined: Testing AAB in Beta for 120 won't be possible (due to language selector relying on this change) which will prevent moving to AAB in 120 release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Once Beta has this change uplifted AND an AAB build has been uploaded to the play store this can be tested. It will be the same process as before which is using the Settings > Language selector and confirming it works (it will either break for all other languages or work for all other languages).
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): bundle { } is only used when creating Android App Bundles so this is ignored for all APK's. Additionally, this just keeps strings together so this has no detrimental effects and is well documented here:
  https://developer.android.com/guide/app-bundle/configure-base#disable_config_apks
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9362422 [details] [review]
[mozilla-mobile/firefox-android] Bug 1860186 - Dont split languages in AAB (backport #4174) (#4399)

Approved for Mobile 120.0b8

Comment 8

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/258c3222c1996814198dc1f55c3f38f1f1f5ef5b
[releases_v120] Bug 1860186 - Dont split languages in AAB

Comment 9

[Lorand Janos]

This will only be verifiable from Beta 121 and onwards.
Removing the qa-verify+ flag