1882138 - In-app language switching doesn't work

Status: VERIFIED FIXED

(Focus :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

As reported by Delphine, we've seen reports that in-app language switching isn't working for Focus starting with v123. Very likely related to the AAB switch. We had to make adjustments to Fenix in bug 1860186 that likely need to be made for Focus also.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (#5775)

Comment 2

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/62a2b3c764dfd71b638a23a2380fefd23e1ccb08
[main] Bug 1882138 - Dont split languages in AAB

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zmckenney, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (backport #5775) (#5842)

Comment 5

[Zac McKenney [:zmckenney]]

Comment on attachment 9388757 [details] [review]
[mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (backport #5775) (#5842)

Beta/Release Uplift Approval Request

• User impact if declined: language selection will not work in-app without this change.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Change the in-app language from Focus settings to anything other than the default OS language. This should now change all of the settings strings to the correct language.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only keeps all of the string resources from the languages in the base APK instead of splitting them into resources for Google to serve from the Play Store. This is in line with how it was done before and is very low risk.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9388757 [details] [review]
[mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (backport #5775) (#5842)

Approved for Mobile 124.0b6

Comment 7

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/be3526cf37dd82b44a73c138e3fdb6d17b757fa5
[releases_v124] Bug 1882138 - Dont split languages in AAB (#5842)

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (backport #5775) (backport #5842) (#5843)

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9388791 [details] [review]
[mozilla-mobile/firefox-android] Bug 1882138 - Dont split languages in AAB (backport #5775) (backport #5842) (#5843)

See comment 5 as the answers are identical

Comment 10

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/8112230057132cad76d0b17b7b6818f22fb4efba
[releases_v123] Bug 1882138 - Dont split languages in AAB (backport #5775) (backport #5842) (#5843)

Comment 11

[Mira Lobontiu (Android QA)]

Verified on Focus Nightly 125.0a1 from 3/4, Beta 124.0b6, and RC 123.0, with a Google Pixel 6 (Android 14), and a Lenovo tablet M10 (Android 10).
Changing the in-app language from Focus settings to anything other than the default OS language, changes all of the settings strings to the correct language.