1860247 - Poison.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1857751 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/9f6a9e601b2ab9ad1a3877691ea17c66c1fd8867/mfbt/Poison.cpp#122-133

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Massa B. Tamfu]

Attachment: Fixed Bug 1860247 Poison.cpp: Avoid using 'else' after 'return'

Comment 2

[Simon Rwat]

Attachment: Poison.cpp

Fixed Bug 1860247 Poison.cpp: Avoid using 'else' after 'return'

Comment 3

[Simon Rwat]

Attachment: poison cpp.png

Fixed Bug 1860247 Poison.cpp: Avoid using 'else' after 'return'

Comment 4

[Simon Rwat]

Hi Sylvestre Ledru,

Thanks for the opportunity, I was opportune to find some time to participate in this contribution. I handled the bug on Bug 1860247. I unfortunately got out of surgery recently and was not able to be as forthcoming with my presence as required but regardless, I am happy to get your feedback.

I am aware your hands and schedule must be occupied at the moment so any response I can get whenever you can spare some time would be appreciated.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Massa is already working on it
Sorry

Comment 6

[Simon Rwat]

Ok I will attend to another one thanks.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Needinfo should be used only when you need an answer. Please use it wisely

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 9

[Maaz I.]

Attachment: Bug 1860247 - Poison.cpp: do not use 'else' after 'return'. r=sylvestre

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f50647366746
Poison.cpp: do not use 'else' after 'return'. r=sylvestre

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f50647366746