1860531 - Extend and update SERP telemetry configuration for mobile

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

In bug 1834842, the android client is currently adding remote settings support for their SERP telemetry. We want them to use the same configuration as desktop, but there are some differences that we'll need to extend the current SERP telemetry collection with a new field.

The new field should be called queryParamNames and is an array of strings. The values of this will duplicate queryParamName, but be added to so that we can support mobile, which needs different parameter names for Baidu.

Older desktop clients will continue to use queryParamName, however new desktop clients and the mobile clients will use queryParamNames.

We'll also need to make sure that the rest of the current configuration also works for mobile.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r?#search-reviewers!

This is a new option that allows specifying multiple query parameter names, so that we can support
some search engines on mobile, where they use a different parameter name to desktop.

A future changeset will make 'queryParamNames' a required parameter.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1860531 - Update SERP telemetry configuration with changes to work for mobile as well. r?#search-reviewers!

Depends on D191647

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1860531 - Use the new queryParamNames SERP telemetry parameter by default. r?#search-reviewers!

Depends on D191648

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/137521f84a32
Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r=search-reviewers,jteow

Comment 5

[Mark Banner (:standard8)]

The remote settings changes are now approved on stage. Please can QA test this?

For testing:

• Existing builds should be unaffected by the changes wrt to SERP telemetry for most engines that we record, except for Baidu.
  • Baidu should start recording for urls such as https://m.baidu.com/s?wd=test (as well as the existing www. version).
• Builds with the full set of patches, should also be unchanged for all engines except Baidu.
  • These try builds have the full set of patches. We'll land the other patch once the changes are on production.
  • Baidu will now also record for urls such as https://m.baidu.com/s?word=test (note: change of parameter name).

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/137521f84a32

Comment 7

[Mark Banner (:standard8)]

Additional item to comment 5:

• Google has been updated to adjust the ad server regular expressions. For desktop, this should not cause a change in the recording of ads on pages.

Comment 8

[Mark Banner (:standard8)]

QA request moved to bug 1861676.

Comment 9

[Phabricator Automation]

Comment on attachment 9359807 [details]
Bug 1860531 - Update SERP telemetry configuration with changes to work for mobile as well. r?#search-reviewers!

Revision D191648 was moved to bug 1861676. Setting attachment 9359807 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9359808 [details]
Bug 1860531 - Use the new queryParamNames SERP telemetry parameter by default. r?#search-reviewers!

Revision D191649 was moved to bug 1861676. Setting attachment 9359808 [details] to obsolete.

Comment 11

[Mark Banner (:standard8)]

Marking as fixed as attachment 9359806 [details] has landed and the other bugs are moved out.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 9359806 [details]
Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r?#search-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: This is effectively a test-only change. It is an update to a schema that we validate against when the search-telemetry-v2 collection is updated from remote settings.

An update will be released soon which will need the new schema for the xpcshell-test to carry on passing.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test-only change.
• String changes made/needed: None
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: See previous description
• User impact if declined: None
• Fix Landed on Version: 121
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test-only change.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9359806 [details]
Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r?#search-reviewers!

Approved for 115.5esr

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/0389f9005998

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9359806 [details]
Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r?#search-reviewers!

Approved for 120.0b4

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e810d109e10d

Comment 17

[Donal Meehan [:dmeehan]]

Comment on attachment 9359806 [details]
Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r?#search-reviewers!

Approved for 119.0.1

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/fcba6e5e74e2