1860668 - Convert ActivityStreamPrefs.jsm to an ESM

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

What's blocking this work is that there are several mocha/chai tests under browser/components/newtab/test/unit/lib that fake out importing ActivityStreamPrefs.jsm using an injection tool that just won't work with ESMs.

This is blocking ESMification. This bug will update those tests to not use injection (which may require me to convert them to xpcshell tests), and then convert ActivityStreamPrefs.jsm to an ESM.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey Scott, so just keeping you in the loop on what I'm slogging through here - the mocha/chai environment that several newtab tests run in use a special injector to mock out / override some JSM loads in the mocha test runner environment. That injector is not compatible with ES6 modules.

I've tried a few approaches here, and unfortunately, I think the best way forward here is probably to convert those tests using the injection to xpcshell tests. This means giving up mocha/chai for those.

I'm in the midst of converting the following tests to xpcshell tests to avoid the injector for ActivityStreamPrefs.jsm:

• browser/components/newtab/test/unit/lib/Store.test.js
• browser/components/newtab/test/unit/lib/TopSitesFeed.test.js
• browser/components/newtab/test/unit/lib/TopStoriesFeed.test.js

Apologies in advance - these patches are not really going to be fun to review.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1860668 - Convert Store.test.js to an xpcshell test. r?thecount!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1860668 - Convert TopSitesFeed.test.js into an xpcshell test. r?thecount!

This is a handwritten conversion of the TopSitesFeed.test.js tests to
xpcshell. Along the way, some of the tests have been dropped - specifically,
tests for pseudoprivate methods on TopSitesFeed that start with _.

The only exception is the Contile integration tests that call
._contile._fetchSites, as those seem fairly important to retain coverage for.

Depends on D192630

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1860668 - Remove TopStoriesFeed.test.js. r?thecount!

This feed is no longer in use by the main distribution of Firefox, and we're
not doing manual QA on it nor changing it. It's blocking our ability to migrate
to ESMs, so we're removing the test altogether. Someday soon, we can hopefully
remove TopStoriesFeed.jsm itself.

Depends on D193473

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1860668 - Adjust Istanbul coverage thresholds for Store.jsm and TopSitesFeed.jsm. r?thecount!

Depends on D193488

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1860668 - Convert ActivityStreamPrefs from a JSM to an ESM. r?thecount!

Depends on D193489

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa50fe1f58d4
Convert Store.test.js to an xpcshell test. r=thecount
https://hg.mozilla.org/integration/autoland/rev/6de5000684a8
Convert TopSitesFeed.test.js into an xpcshell test. r=thecount
https://hg.mozilla.org/integration/autoland/rev/c388d81bf3be
Remove TopStoriesFeed.test.js. r=thecount
https://hg.mozilla.org/integration/autoland/rev/3a63a5894552
Adjust Istanbul coverage thresholds for Store.jsm and TopSitesFeed.jsm. r=thecount
https://hg.mozilla.org/integration/autoland/rev/ae0d0f96b661
Convert ActivityStreamPrefs from a JSM to an ESM. r=thecount
https://hg.mozilla.org/integration/autoland/rev/7044de24075f
apply code formatting via Lando

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fa50fe1f58d4
https://hg.mozilla.org/mozilla-central/rev/6de5000684a8
https://hg.mozilla.org/mozilla-central/rev/c388d81bf3be
https://hg.mozilla.org/mozilla-central/rev/3a63a5894552
https://hg.mozilla.org/mozilla-central/rev/ae0d0f96b661
https://hg.mozilla.org/mozilla-central/rev/7044de24075f