Closed Bug 1869955 Opened 6 months ago Closed 6 months ago

Perma xpcshell browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | xpcshell return code: 0 | test_ContileIntegration - [test_ContileIntegration : 3119] false == true

Categories

(Firefox :: New Tab Page, defect, P5)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox120 --- unaffected
firefox121 --- unaffected
firefox122 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mconley)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Attachments

(2 files)

Bug 1869955 - disable test_TopSitesFeed.js for Xpcshell perma failures. r=#intermittent-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1869955 - Fix test_TopSitesFeed to use seconds instead of milliseconds. r?Standard8!
48 bytes, text/x-phabricator-request
Details | Review

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=440066226&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dtYrMaqIRByEEJWh9ZzR5A/runs/0/artifacts/public/logs/live_backing.log

[task 2023-12-14T02:14:37.379Z] 02:14:37     INFO -  TEST-START | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js
[task 2023-12-14T02:14:39.830Z] 02:14:39  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | xpcshell return code: 0
[task 2023-12-14T02:14:39.830Z] 02:14:39     INFO -  TEST-INFO took 2433ms
[task 2023-12-14T02:14:39.830Z] 02:14:39     INFO -  >>>>>>>
[task 2023-12-14T02:14:39.830Z] 02:14:39     INFO -  PID 6412 | [Parent 6412, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2886
[task 2023-12-14T02:14:39.830Z] 02:14:39     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-12-14T02:14:39.830Z] 02:14:39     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-12-14T02:14:39.831Z] 02:14:39     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-12-14T02:14:39.831Z] 02:14:39     INFO -  running event loop
[task 2023-12-14T02:14:39.831Z] 02:14:39     INFO -  browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | Starting setup
[task 2023-12-14T02:14:39.832Z] 02:14:39     INFO -  (xpcshell/head.js) | test pending (2)
[task 2023-12-14T02:14:39.832Z] 02:14:39     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-12-14T02:14:39.832Z] 02:14:39     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-12-14T02:14:39.832Z] 02:14:39     INFO -  (xpcshell/head.js) | test finished (2)
[task 2023-12-14T02:14:39.833Z] 02:14:39     INFO -  browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | Starting test_construction
[task 2023-12-14T02:14:39.833Z] 02:14:39     INFO -  (xpcshell/head.js) | test test_construction pending (2)
[task 2023-12-14T02:14:39.833Z] 02:14:39     INFO -  TEST-PASS | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | test_construction - [test_construction : 135] Could construct a TopSitesFeed - [object Object] == true
<...>
[task 2023-12-14T02:14:40.213Z] 02:14:40     INFO -  TEST-PASS | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | test_ContileIntegration - [test_ContileIntegration : 3093] true == true
[task 2023-12-14T02:14:40.213Z] 02:14:40     INFO -  TEST-PASS | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | test_ContileIntegration - [test_ContileIntegration : 3094] true == true
[task 2023-12-14T02:14:40.213Z] 02:14:40     INFO -  "TopSitesFeed._fetchSites should return false when Contile returns with error status and cached tiles are expried"
[task 2023-12-14T02:14:40.214Z] 02:14:40     INFO -  PID 6412 | console.warn: TopSitesFeed: Contile endpoint returned unexpected status: 500
[task 2023-12-14T02:14:40.214Z] 02:14:40  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/newtab/test/xpcshell/test_TopSitesFeed.js | test_ContileIntegration - [test_ContileIntegration : 3119] false == true
[task 2023-12-14T02:14:40.215Z] 02:14:40     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/newtab/test/xpcshell/test_TopSitesFeed.js:test_ContileIntegration:3119
[task 2023-12-14T02:14:40.215Z] 02:14:40     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:245
[task 2023-12-14T02:14:40.216Z] 02:14:40     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:592
[task 2023-12-14T02:14:40.216Z] 02:14:40     INFO -  -e:null:1
[task 2023-12-14T02:14:40.216Z] 02:14:40     INFO -  exiting test
[task 2023-12-14T02:14:40.217Z] 02:14:40     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2023-12-14T02:14:40.217Z] 02:14:40     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:865:20
[task 2023-12-14T02:14:40.217Z] 02:14:40     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:977:5
[task 2023-12-14T02:14:40.218Z] 02:14:40     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:70:21
[task 2023-12-14T02:14:40.218Z] 02:14:40     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:244:10
[task 2023-12-14T02:14:40.218Z] 02:14:40     INFO -  Assert.prototype.ok@resource://testing-common/Assert.sys.mjs:270:10
[task 2023-12-14T02:14:40.219Z] 02:14:40     INFO -  test_ContileIntegration@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/newtab/test/xpcshell/test_TopSitesFeed.js:3119:12
[task 2023-12-14T02:14:40.219Z] 02:14:40     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2023-12-14T02:14:40.220Z] 02:14:40     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:592:5
[task 2023-12-14T02:14:40.220Z] 02:14:40     INFO -  @-e:1:1
[task 2023-12-14T02:14:40.220Z] 02:14:40     INFO -  exiting test
[task 2023-12-14T02:14:40.221Z] 02:14:40     INFO -  PID 6412 | [Parent 6412, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3376
[task 2023-12-14T02:14:40.221Z] 02:14:40     INFO -  PID 6412 | [Parent 6412, Main Thread] WARNING: XPCOM object PerThreadData destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:216
[task 2023-12-14T02:14:40.222Z] 02:14:40     INFO -  PID 6412 | [Parent 6412, Main Thread] WARNING: XPCOM object SourceList destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:216
[task 2023-12-14T02:14:40.222Z] 02:14:40     INFO -  <<<<<<<
[task 2023-12-14T02:14:40.222Z] 02:14:40     INFO -  TEST-START | toolkit/mozapps/update/tests/unit_aus_update/updateSyncManager.js

This appeared as new test and started permafailing once Bug 1866802 landed, while also affecting other trees. It was backed out, however the issue is still present, possibly making it an external issue. We will temporarily disable the test until a fix can be provided.

Flags: needinfo?(mconley)
Assignee: nobody → abutkovits
Status: NEW → ASSIGNED
Pushed by nfay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18f2793d82db
Temporarily disable test_TopSitesFeed.js subtest for causing permafailures r=mconley CLOSED TREE

I took a look at this, and I think there's a couple of problems in the test, specifically here

The issue is that the preference is being set as milliseconds rather than seconds, as it is elsewhere in the test.

If we put a millisecond date into preferences, it overflows approximately every 50 days. Although the test has been broken for a while, the reason we didn't see this before, is that this used to be run under the mocha unit test harness, where there was a mocked preference service, this mocked service was implemented in JavaScript and does not have the integer overflow issues of the real pref service.

I think there may also be some other things wrong - thecacheValidFor is being set as if it was milliseconds, but it looks like it is seconds. It would be nice if that was documented near the constants.

This piece of the test also seems to be setting the values the wrong way around (as well as making the 1000 * mistake).

https://hg.mozilla.org/mozilla-central/rev/18f2793d82db

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

This was only disabling the test and should have been left open.

Assignee: abutkovits → nobody
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

Unit testing strikes again! Let me see if I can patch this and re-enable the subtest.

Assignee: nobody → mconley
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/338e9195675e
Fix test_TopSitesFeed to use seconds instead of milliseconds. r=Standard8
Keywords: leave-open
Regressed by: 1860668
No longer regressed by: 1866802

Set release status flags based on info from the regressing bug 1860668

status-firefox120: --- → unaffected
status-firefox121: --- → unaffected
status-firefox122: --- → affected
status-firefox-esr115: --- → unaffected

https://hg.mozilla.org/mozilla-central/rev/338e9195675e

Status: REOPENED → RESOLVED
Closed: 6 months ago → 6 months ago
status-firefox122: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: