1860766 - Menulists in preferences have smaller dropmarkers now.

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Before the dropmarker used to be 16px because this was not in effect, because the list-style-image was set on the dropmarker icon.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1860766 - Clean-up in-content menulist styles. r=dao

Before bug 1860385, we used the 16px image (because the list-style-image
was set on the icon, and in-content/common-shared.css rule didn't
override it). But the dropmarker was still 12px wide, and the 4px
margin-inline-end of common-shared.css did fix it.

That's pretty messy. Remove the dropmarker sizes so that the dropmarker
takes the right size based on the dropmarker icon. That means that if
somebody wants a 16px icon they can just override list-style-image on
the dropmarker.

Use the 12px dropmarker arrow since that's what we also do for <select>,
and seems to be the general intention.

This also avoids the need of manually positioning it on windows to be
centered-ish vertically.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1860766 - Use content: url() for custom dropmarkers. r=dao

This is simpler and closer to how a regular image would behave.

Move dropmarker styles to xul.css, and remove the dropmarker custom
element that just wraps an <image>.

Also remove the button[type="disclosure"] rules since they're unused
while at it (and macOS has no styles for that).

Depends on D191736

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1860385

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7233a41013d0
Clean-up in-content menulist styles. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/16f60efaa83b
Use content: url() for custom dropmarkers. r=dao,desktop-theme-reviewers

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_interaction-between-interfaces.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bfd2855924f21f5096d9945383d4cb1326283fea

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=16f60efaa83b3856fbc23bf73616811e7dd796ff&selectedTaskRun=V5S53RaBTe-eXtP-0DHd0A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=433637728&repo=autoland&lineNumber=19419

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/564a91732aa1
Clean-up in-content menulist styles. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/ca283022c693
Use content: url() for custom dropmarkers. r=dao,desktop-theme-reviewers

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/564a91732aa1
https://hg.mozilla.org/mozilla-central/rev/ca283022c693

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing permafailures on test_focus.xhtml

• backout: https://hg.mozilla.org/integration/autoland/rev/1c61a469895e19d959dbe093757e3fbcc1a606f1
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=UTI_NITJTBeTwemo4KNdRw.0&revision=ca283022c693913c2cc48e7772de3534c5c60d20
• failure log: https://treeherder.mozilla.org/logviewer?job_id=433817217&repo=autoland&lineNumber=9276

[task 2023-10-25T23:14:11.528Z] 23:14:11     INFO - TEST-PASS | dom/tests/mochitest/chrome/test_focus.xhtml | mouse on element t14 activeElement for parent 
[task 2023-10-25T23:14:11.528Z] 23:14:11     INFO - Buffered messages finished
[task 2023-10-25T23:14:11.529Z] 23:14:11     INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/chrome/test_focus.xhtml | mouse on element t12 events - got "commandupdate: cu blur: t14", expected "commandupdate: cu blur: t14 blur: child-document blur: child-window focus: outer-document focus: outer-window commandupdate: cu focus: t12"
[task 2023-10-25T23:14:11.529Z] 23:14:11     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2023-10-25T23:14:11.529Z] 23:14:11     INFO - is@chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/window_focus.xhtml:49:55
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - compareEvents@chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/window_focus.xhtml:200:5
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - expectFocusShift@chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/window_focus.xhtml:190:16
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - mouseOnElement@chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/window_focus.xhtml:326:21
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - startTest@chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/window_focus.xhtml:462:19
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2023-10-25T23:14:11.531Z] 23:14:11     INFO - Not taking screenshot here: see the one that was previously logged

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1860385

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0ec89ef7099
Clean-up in-content menulist styles. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/4d2c1911361b
Use content: url() for custom dropmarkers. r=dao,desktop-theme-reviewers

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e0ec89ef7099
https://hg.mozilla.org/mozilla-central/rev/4d2c1911361b