1845836 - Include closed tabs from closed windows in firefoxview-next's recently closed tabs list

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement, P3)

Description

[Sam Foster [:sfoster] (he/him)]

Rather than try to boil the whole ocean, I want to first tackle the smaller problem of getting the new recently-closed tabs listing in about:firefoxview-next including closed tabs from closed windows. This will be behind a new pref and will let me get some of the SessionStore implementation changes in place without simultaneously needing to update all the other history menus and their tests.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1845836 - Include closed tabs from closed windows in fxview-next's recently closed tabs list. r?dao!,kcochrane

• Add a browser.sessionstore.closedTabsFromClosedWindows pref and consult it when building recently-closed tab lists in firefoxview-next
• Add a _resolveClosedDataSource to SessionStore which allows us to find the window state and _closedTabs given a DOMWindow, a window closedId, or a window session store Id.
• Carry window closedId and source window Id into tab items when building recently-closed tab lists in firefoxview-next. This gives us the necessary context when we need to undoClose or forget a tab item in the list.
• Add a getClosed TabCount and TabData for Closed Windows method to SessionStore
• Modify undoCloseTab and forgetClosedTab to accept source params we can resolve to window state data using _resolveClosedDataSource

Status

• The SessionStore API is still in flux. I want to avoid incompatible changes to existing methods allowing incremental development with callers continuing to work as before until I get to them
• Any closed tabs are lost if a window closes with 0 worth-keeping open tabs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faca0b32a214
Include closed tabs from closed windows in fxview-next's recently closed tabs list. r=kcochrane,dao,fxview-reviewers,sessionstore-reviewers,sclements

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/faca0b32a214