Open Bug 1860985 Opened 1 year ago Updated 1 year ago

Always use the "navigableIds" map between browsing contexts and uuids to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager`

Categories

(Remote Protocol :: Agent, task, P3)

Product:
Remote Protocol
Component:
Agent
Type:
task

Tracking

(Not tracked)

People

(Reporter: Sasha, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:backlog])

In the scope of the bug1694390, we've introduced the fallback way to access the id for a top browsing context when the context is discarded. But during the review, we've realized we could probably use this approach for all the cases (even if contexts are not discarded), meaning always get the id from the map between browsing contexts and uuids. This might require a different method to create the id and to get the id.

Summary: Always use the map to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager` → Always use the map between browsing contexts and uuids to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager`

The referred discussion actually happened at Phabricator and can be found here.

It's basically that we should use the navigableIds map (that we might also want to rename) instead of the browserUniqueIds cache.

Summary: Always use the map between browsing contexts and uuids to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager` → Always use the "navigableIds" map between browsing contexts and uuids to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager`
Priority: -- → P3
See Also: → 1750604
Whiteboard: [webdriver:backlog]
You need to log in before you can comment on or make changes to this bug.