1860985 - Always use the "navigableIds" map between browsing contexts and uuids to return id for top browsing context in `getIdForBrowsingContext` method of `TabManager`

Status: NEW

(Remote Protocol :: Agent, task, P3)

Description

[Alexandra Borovova [:Sasha]]

In the scope of the bug1694390, we've introduced the fallback way to access the id for a top browsing context when the context is discarded. But during the review, we've realized we could probably use this approach for all the cases (even if contexts are not discarded), meaning always get the id from the map between browsing contexts and uuids. This might require a different method to create the id and to get the id.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

The referred discussion actually happened at Phabricator and can be found here.

It's basically that we should use the navigableIds map (that we might also want to rename) instead of the browserUniqueIds cache.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Bug 1989563 is going to move the maps to a new NavigableManager singleton. I'll update the summary once the code landed.