1694390 - Implement browsingContext.contextDestroyed event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This event is needed for clients to handle browsing contexts that get destroyed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not quite sure yet if this feature is needed for milestone 2 or not. Registered events would automatically be removed when the browsing context closes. Lets discuss in the next triage meeting.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We wrongly assumed 2 points here but there is actually more work to do. Especially because we would have two events (beside contextCreated) in the browsingContext module now which might require a refactoring and ref counting for enabling/disabling internal listeners. As such we see this bug as 8 points.

Comment 3

[alexrudenko]

I believe two tests

    "Page Page.close should not be visible in browser.pages"
    "Page Page.close should set the page close state"

are failing because browsingContext.contextDestroyed is missing.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Resetting priority for discussing a possible re-prioritization to get Puppeteer tests fixed. Maybe P2 backlog or for M9?

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1694390 - [bidi] Implement browsingContext.contextDestroyed event.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1694390 - [wdspec] Add tests for browsingContext.contextDestroyed event.

Depends on D189472

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1694390 - Make TabManager a class.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e975c11128ae
Make TabManager a class. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/8a885c973588
[bidi] Implement browsingContext.contextDestroyed event. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/a98551a11802
[wdspec] Add tests for browsingContext.contextDestroyed event. r=webdriver-reviewers,jdescottes,whimboo

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42745 for changes under testing/web-platform/tests

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e975c11128ae
https://hg.mozilla.org/mozilla-central/rev/8a885c973588
https://hg.mozilla.org/mozilla-central/rev/a98551a11802

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot