Closed Bug 1694390 Opened 5 years ago Closed 2 years ago

Implement browsingContext.contextDestroyed event

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
5

Tracking

(firefox121 fixed)

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Depends on 1 open bug, Blocks 3 open bugs,
URL
)

Details

(Whiteboard: [webdriver:m9][wptsync upstream][webdriver:relnote])

Attachments

(3 files)

Bug 1694390 - [bidi] Implement browsingContext.contextDestroyed event.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694390 - [wdspec] Add tests for browsingContext.contextDestroyed event.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694390 - Make TabManager a class.
48 bytes, text/x-phabricator-request
Details | Review

This event is needed for clients to handle browsing contexts that get destroyed.

Summary: Implement browsingContext.contextDestroyed → Implement browsingContext.contextDestroyed event
Depends on: 1693839
Points: --- → 2
Priority: -- → P2
Whiteboard: [bidi-m1-mvp] → [bidi-m1-mvp] [not-a-fission-bug]
Priority: P2 → P3
Blocks: 1723102
No longer blocks: 1694144
Blocks: 1724669
Whiteboard: [bidi-m1-mvp] [not-a-fission-bug] → [bidi-m2-mvp]
Priority: P3 → --
Blocks: 1730471

Not quite sure yet if this feature is needed for milestone 2 or not. Registered events would automatically be removed when the browsing context closes. Lets discuss in the next triage meeting.

Priority: -- → P3
Blocks: 1731565
No longer blocks: 1724669
No longer blocks: 1723102
Priority: P3 → P2
Whiteboard: [bidi-m2-mvp] → [bidi-m3-mvp]

We wrongly assumed 2 points here but there is actually more work to do. Especially because we would have two events (beside contextCreated) in the browsingContext module now which might require a refactoring and ref counting for enabling/disabling internal listeners. As such we see this bug as 8 points.

Points: 2 → 8
See Also: → 1762334
Depends on: 1762334
See Also: 1762334 →
Priority: P2 → P3
Whiteboard: [bidi-m3-mvp] → [webdriver:backlog]

I believe two tests

    "Page Page.close should not be visible in browser.pages"
    "Page Page.close should set the page close state"

are failing because browsingContext.contextDestroyed is missing.

Resetting priority for discussing a possible re-prioritization to get Puppeteer tests fixed. Maybe P2 backlog or for M9?

Priority: P3 → --
Points: 8 → 5
Priority: -- → P2
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Whiteboard: [webdriver:backlog] → [webdriver:m8]
Whiteboard: [webdriver:m8] → [webdriver:m9]
Blocks: 1860008
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e975c11128ae Make TabManager a class. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/8a885c973588 [bidi] Implement browsingContext.contextDestroyed event. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/a98551a11802 [wdspec] Add tests for browsingContext.contextDestroyed event. r=webdriver-reviewers,jdescottes,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42745 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m9] → [webdriver:m9], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/e975c11128ae
https://hg.mozilla.org/mozilla-central/rev/8a885c973588
https://hg.mozilla.org/mozilla-central/rev/a98551a11802

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m9], [wptsync upstream] → [webdriver:m9][wptsync upstream][webdriver:relnote]
Depends on: 1920952
No longer depends on: 1920952
Depends on: 2022295
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: