Open Bug 1860987 Opened 11 months ago Updated 3 months ago

Change the behavior of the translate=no attribute for the root html node

Categories

(Firefox :: Translations, defect, P3)

Product:
Firefox
Component:
Translations
Type:
defect

Tracking

()

People

(Reporter: chutten, Unassigned)

References

(Blocks 1 open bug)

Details

e.g. https://www.ubereats.com/de/store/sadhu-kreuzberg/dne8YU0hSkKGSkJwrpzh6A

It did correctly detect the language, correctly prompt "hey you wanna translate", appeared to correctly download and apply the model... but the page text remains entirely German.

The body of the page has "class=notranslate" (which means the page is explicitly asking not to be translated). It looks like Uber doesn't want you to order food unless you speak German!

Maybe we could avoid offering translation on pages where every element of the page has "notranslate"? We'll discuss this in our weekly meeting.

Note: Edge implements the exact same behavior as Firefox.

It also has <html translate="no"> : (

I would assume the fix for this bug is to respect the translate="no" by not offering to translate the page. However, if a user goes to the app menu and opens the translations, we should ignore the attribute, and translate the page, but continue to respect the translate attribute for any non-root nodes.

Severity: -- → S3
Priority: -- → P3
Summary: ubereats restaurant order/menu pages: translation doesn't happen (German -> English) → Change the behavior of the translate=no attribute for the root html node

We discussed this today, and we decided to allow users to translate and show the icon in the urlbar without offering the popup in these cases.

We will still respect "translate=no" when it is on non-root nodes.

Blocks: 1861489
Blocks: 1845772
No longer blocks: 1838721, 1861489
You need to log in before you can comment on or make changes to this bug.