Closed Bug 1861173 Opened 1 year ago Closed 1 year ago

Change the timing of the Review Checker onboarding CFR

Categories

(Fenix :: Shopping, enhancement, P1)

Product:
Fenix
Component:
Shopping
Platform:
All
Android
Type:
enhancement

Tracking

(firefox119 disabled, firefox120 verified, firefox121 verified)

Status:
VERIFIED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox119 --- disabled
firefox120 --- verified
firefox121 --- verified

People

(Reporter: verdi, Assigned: vdreghici)

References

Details

(Whiteboard: [fxdroid] [fakespot-android-mvp])

Attachments

(4 files)

[mozilla-mobile/firefox-android] Bug 1861173 - Change timing of the Review Checker onboarding CFR (#4246)
59 bytes, text/x-github-pull-request
Details | Review
[mozilla-mobile/firefox-android] Bug 1861173 - Correctly increment shopping CFR counter (#4352)
59 bytes, text/x-github-pull-request
Details | Review
[mozilla-mobile/firefox-android] Bug 1861173 - Change timing of the Review Checker onboarding CFR (backport #4246) (#4407)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-beta+
Details | Review
[mozilla-mobile/firefox-android] Bug 1861173 - Correctly increment shopping CFR counter (backport #4352) (#4408)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-beta+
Details | Review

The current onboarding CFR is set to show the first time someone lands on a product detail page. If the user dismisses the CFR and does not opt-in, we show it on the next product detail page after at least 24 hours have elapsed.

We'd like to change this, showing the CFR up to 3X (instead of 2) with at least 12 hrs in-between (instead of 24).

Blocks: fenix-fakespot-integration
Severity: -- → N/A
status-firefox119: --- → disabled
status-firefox120: --- → affected
status-firefox121: --- → affected
Priority: -- → P1
Whiteboard: [fxdroid] [fakespot-android-mvp]
Assignee: nobody → Vlad.DreghiciPopa
Status: NEW → ASSIGNED

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/dddeecc082a9be8dcc53caddc5bec79753fff9bb
[main] Bug 1861173 - Change timing of the Review Checker onboarding CFR

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox121: affected → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also: → 1862962

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/67b68c948b76ea86294c91d520ee0b58d3b31fdf
[main] Bug 1861173 - Correctly increment shopping CFR counter

Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → FIXED
Blocks: 1862962
See Also: 1862962 →

Vlad, should we uplift this fix to Beta 120?

Flags: needinfo?(Vlad.DreghiciPopa)
See Also: → 1863504

Verified as fixed on the latest Nightly 121.0a1 from 08.11.2023 with Motorola G9 plus (Android 11) and Sony Xperia (Android 6.0.1). The CFR is shown up to 3X (instead of 2) with at least 12 hrs in-between (instead of 24).

status-firefox121: fixed → verified
Flags: qe-verify+

Comment on attachment 9362548 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861173 - Change timing of the Review Checker onboarding CFR (backport #4246) (#4407)

Beta/Release Uplift Approval Request

  • User impact if declined: The user will not see the CFR 3 times after 12 hours, as it is now intended, instead, it will appear only twice after 24 hours, as before.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same steps as verification in nightly.
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is not risky because we just add an extra check for a value that is incremented every time the user sees the CFR and change the time between displays to 12 hours instead of 24.
  • String changes made/needed: none
  • Is Android affected?: Yes
Flags: needinfo?(Vlad.DreghiciPopa)
Attachment #9362548 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9362549 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861173 - Correctly increment shopping CFR counter (backport #4352) (#4408)

Beta/Release Uplift Approval Request

  • User impact if declined: Incrementing the shown CFR counter was not done correctly. This patch fixes than, so it will only be shown 3 times and not anymore after that.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same steps as used in nightly.
  • List of other uplifts needed: https://bugzilla.mozilla.org/attachment.cgi?id=9362548
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is not risky because we just change how we increment the CFR shown counter.
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9362549 - Flags: approval-mozilla-beta?
Comment on attachment 9362548 [details] [review] [mozilla-mobile/firefox-android] Bug 1861173 - Change timing of the Review Checker onboarding CFR (backport #4246) (#4407) Approved for Mobile 120.0b8
Attachment #9362548 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 9362549 [details] [review] [mozilla-mobile/firefox-android] Bug 1861173 - Correctly increment shopping CFR counter (backport #4352) (#4408) Approved for Mobile 120.0b8
Attachment #9362549 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the Beta 120.0b8 build with Sony Xperia Z5 Premium (Android 7.1.1).
The CFR is displayed 3 times, with at least 12 hrs in between.

Status: RESOLVED → VERIFIED
status-firefox120: fixed → verified
Flags: qe-verify+
Regressions: 1863507
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: