Closed Bug 1863504 Opened 1 year ago Closed 1 year ago

Track Shopping CFR shown to user when it is displayed

Categories

(Fenix :: Shopping, task)

Product:
Fenix
Component:
Shopping
Platform:
All
Android
Type:
task

Tracking

(firefox120 verified, firefox121 verified)

Status:
VERIFIED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox120 --- verified
firefox121 --- verified

People

(Reporter: vdreghici, Assigned: vdreghici)

References

Details

(Whiteboard: [fxdroid] [fakespot-android-mvp] )

Attachments

(3 files)

[mozilla-mobile/firefox-android] Bug 1863504 - Track Shopping CFR shown to user when it is displayed (#4392)
59 bytes, text/x-github-pull-request
Details | Review
CFR1.mov
1.80 MB, video/quicktime
Details
[mozilla-mobile/firefox-android] Bug 1863504 - Track Shopping CFR shown to user when it is displayed (backport #4392) (#4410)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-beta+
Details | Review

Rather than tracking that the CFR was shown to the user when the user explicitly interacts with it, we will track it when the CFR was shown, not considering how the user dismissed it.

Assignee: nobody → Vlad.DreghiciPopa
Status: NEW → ASSIGNED
See Also: → 1862962
Whiteboard: [fxdroid] [fakespot-android-mvp]
See Also: → 1861173

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/1803de59619a12c68e20c582d74ca25b971ba402
[main] Bug 1863504 - Track Shopping CFR shown to user when it is displayed

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox121: --- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch

Verified as fixed on the latest Nightly 121.0a1 from 08.11.2023 with Motorola G9 plus (Android 11) and OnePlus A3000 (Android 6). The CFR is shown when the user lands on a PDP page and is no longer triggered repeatedly when moving to a different page from the menu and returning.

status-firefox121: fixed → verified
Flags: qe-verify+

Comment on attachment 9362554 [details] [review]
[mozilla-mobile/firefox-android] Bug 1863504 - Track Shopping CFR shown to user when it is displayed (backport #4392) (#4410)

Beta/Release Uplift Approval Request

  • User impact if declined: This patch updates the CFR settings when the CFR is actually shown to the user, instead of when the user has explicitly interacted with it. This way, we can avoid any problems that might appear when the user implicitly interacts with the CFR.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same steps as the ones used in nightly.
  • List of other uplifts needed: Both uplifts from 1861173: https://github.com/mozilla-mobile/firefox-android/pull/4407 & https://github.com/mozilla-mobile/firefox-android/pull/4408
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is not risky because we just changed when we update the settings for CFR to when it is shown instead of when the user tapped dismiss or the action in it.
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9362554 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Comment on attachment 9362554 [details] [review] [mozilla-mobile/firefox-android] Bug 1863504 - Track Shopping CFR shown to user when it is displayed (backport #4392) (#4410) Approved for Mobile 120.0b8
Attachment #9362554 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the Beta 120.0b8 with Sony Xperia z5 Premium (Android 7.1.1).
The CFR is displayed to the user, wether the user has explicitly interacted with it or not.

Status: RESOLVED → VERIFIED
status-firefox120: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: