1861346 - Radio inputs after checked input have indeterminate style on page load

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[julian]

Attachment: Screenshot of incorrect :indeterminate style applied on page load

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

I have a group of radio buttons that use the :indeterminate CSS selector. A minimal reproducible example follows:

CSS:

input[type=radio]:indeterminate + label {
  background: red;
}
input[type=radio]:checked + label {
  background: green;
}

HTML:

<form>
  <input type="radio" name="a" id="one" value="1">
  <label for="one">One</label>
  
  <input type="radio" name="a" id="two" value="2" checked> 
  <label for="two">Two</label>
  
  <input type="radio" name="a" id="three" value="3"> 
  <label for="three">Three</label>
  
  <input type="radio" name="a" id="four" value="4"> 
  <label for="four">Four</label>
</form>

Tested on:

• Windows 11 22H2 / Firefox Nightly 121.0a1 (2023-10-25) (64-bit)
• Ubuntu 22.04.3 (WSL2) / Firefox Nightly 121.0a1 (2023-10-25) (64-bit)

Actual results:

The radio inputs following the checked radio will have the :indeterminate style applied, i.e. have a red label background on page load.

Selecting a different input removes the :indeterminate style on all radio inputs in the group.

Expected results:

If one radio input in a group is checked, none of the inputs in the same group should have :indeterminate applied.

I also confirmed this works as expected in other browsers.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Attachment: reporter's testcase

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c3cb8e669cc2fbfeadba2eed88bbef838cd8a3ad&tochange=2db6638a3d8a17c7770a04473a79e7dd3f1fcc74

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1850293, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c50d066111a
Update indeterminate state when getting added or removed from a radio group. r=smaug

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c50d066111a

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42826 for changes under testing/web-platform/tests

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Original Revision: https://phabricator.services.mozilla.com/D191949

Comment 11

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: comment 0
• Code covered by automated testing: yes
• User impact if declined: comment 0
• String changes made/needed: none
• Is Android affected?: yes
• Risk associated with taking this patch: Low
• Explanation of risk level: Very simple tweak.
• Needs manual QE test: yes
• Fix verified in Nightly: yes

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9360972 [details]
Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Approved for 120.0b5

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f86cd37a37d

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Donal Meehan [:dmeehan]]

:emilio wha'ts the severity on this?
Is this safe to get a release uplift request for inclusion in next week's dot release?

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Original Revision: https://phabricator.services.mozilla.com/D191949

Comment 18

[Phabricator Automation]

Uplift Approval Request

• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Explanation of risk level: Trivial well-scoped change.
• Risk associated with taking this patch: low
• Is Android affected?: yes
• String changes made/needed: none
• User impact if declined: See above
• Code covered by automated testing: yes
• Steps to reproduce for manual QE testing: comment 0

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Yeah

Comment 20

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 121.0a1 (2023-10-31) on Windows 11 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 21

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 120.0b5 on Windows 11 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 22

[Donal Meehan [:dmeehan]]

Comment on attachment 9361185 [details]
Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Approved for 119.0.1

Comment 23

[Donal Meehan [:dmeehan]]

Comment on attachment 9361185 [details]
Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Setting the approval back to pending
The patch failed to land due to conflicts
https://lando.services.mozilla.com/D192322/

Comment 24

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861346 - Update indeterminate state when getting added or removed from a radio group.

Original Revision: https://phabricator.services.mozilla.com/D191949

Comment 25

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: yes
• User impact if declined: comment 0
• Explanation of risk level: trivialish fix
• Risk associated with taking this patch: low
• Code covered by automated testing: yes
• Steps to reproduce for manual QE testing: comment 0
• Is Android affected?: yes
• String changes made/needed: none
• Fix verified in Nightly: yes

Comment 26

[Emilio Cobos Álvarez (:emilio)]

comment 24 is a rebase.

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/f8c9a830f7b6

Comment 28

[Donal Meehan [:dmeehan]]

Comment on attachment 9362022 [details]
Bug 1861346 - Update indeterminate state when getting added or removed from a radio group.

Thanks
Approved for 119.0.1

Comment 29

[Donal Meehan [:dmeehan]]

Comment on attachment 9361185 [details]
Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug

Rejecting uplift request, replaced with Comment 24

Comment 30

[Donal Meehan [:dmeehan]]

Backed out for causing build failures in release.

Backout:
https://hg.mozilla.org/releases/mozilla-release/rev/ff4255011d2c4eb5e7454df4bbca950b56aa1808

Failures:
https://treeherder.mozilla.org/jobs?repo=mozilla-release&revision=f8c9a830f7b6de5fbca49073fdbb9ada484bf4d2

/dom/html/HTMLInputElement.cpp:6254:27: error: use of undeclared identifier 'container'
bool indeterminate = !container->GetCurrentRadioButton(name);
/dom/html/HTMLInputElement.cpp:6254:60: error: use of undeclared identifier 'name'
bool indeterminate = !container->GetCurrentRadioButton(name);

Comment 31

[Emilio Cobos Álvarez (:emilio)]

Attachment: Fixed-up release patch

Ah, yeah, so this depends on bug 1685926. Here's a fixed up patch to not depend on it.

Comment 32

[Donal Meehan [:dmeehan]]

Comment on attachment 9362090 [details]
Fixed-up release patch

Approved for 119.0.1

Comment 33

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b8f0d32ac6a5

Comment 34

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 119.0.1 on Windows 11 x64, macOS 11.6 and on Ubuntu 20.04 x64