1850293 - Remove some more intrinsic states.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make directionality state not intrinsic. r=smaug!

Allows us to reclaim some node bits too.

Depends on D186877

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make INCREMENT_SCRIPT_LEVEL state non intrinsic. r=smaug,fredw

Depends on D186893

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make <meter> styles not intrinsic. r=smaug,edgar

This one needs extra code because we have an UpdateState call after
AfterSetAttr which took care of it.

Depends on D186894

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make editable states not intrinsic. r=smaug,masayuki

This one is tricky because form controls, though I think I got it right...

Depends on D186895

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make PLACEHOLDER_SHOWN not an intrinsic state. r=smaug,edgar

Depends on D186896

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make CHECKED/DEFAULT states not intrinsic. r=smaug,edgar

Depends on D186932

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make in-range/out-of-range states non-intrinsic. r=smaug,edgar

These only apply to input, so it's rather trivial-ish.

Depends on D186933

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa4b8bfa49a9
Make directionality state not intrinsic. r=smaug

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ca65a951fc
Make INCREMENT_SCRIPT_LEVEL state non intrinsic. r=smaug

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13449f0dcd4d
Make <meter> styles not intrinsic. r=edgar

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95fb96c0db31
Make PLACEHOLDER_SHOWN not an intrinsic state. r=smaug

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make indeterminate state non-intrinsic. r=smaug,edgar

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fa4b8bfa49a9
https://hg.mozilla.org/mozilla-central/rev/a9ca65a951fc
https://hg.mozilla.org/mozilla-central/rev/13449f0dcd4d
https://hg.mozilla.org/mozilla-central/rev/95fb96c0db31

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Make validity states non-intrinsic. r=smaug,edgar

Add a RAII helper to notify of multiple state changes together for
these.

Depends on D187005

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850293 - Don't use IntrinsicState() in VideoFrame constructor. r=padenot

State() is cheaper, and non-virtual, and should be up-to-date. I'm
removing the concept of "intrinsic" states and this caught my eye.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b02c7357724
Make editable states not intrinsic. r=smaug,masayuki
https://hg.mozilla.org/integration/autoland/rev/e2901434f15d
Make CHECKED/DEFAULT states not intrinsic. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a033e3702f2e
Make in-range/out-of-range states non-intrinsic. r=smaug
https://hg.mozilla.org/integration/autoland/rev/beb7d600e03d
Make indeterminate state non-intrinsic. r=edgar
https://hg.mozilla.org/integration/autoland/rev/083153001b0d
Make validity states non-intrinsic. r=smaug

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41710 for changes under testing/web-platform/tests

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d88a18607fdb
Don't use IntrinsicState() in VideoFrame constructor. r=smaug

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4b02c7357724
https://hg.mozilla.org/mozilla-central/rev/e2901434f15d
https://hg.mozilla.org/mozilla-central/rev/a033e3702f2e
https://hg.mozilla.org/mozilla-central/rev/beb7d600e03d
https://hg.mozilla.org/mozilla-central/rev/083153001b0d
https://hg.mozilla.org/mozilla-central/rev/d88a18607fdb

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot