1861349 - Certificate Manager table column can not be resized

Status: VERIFIED FIXED

(Core :: Security: PSM, defect)

Description

[David Balažic]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

• Open Settings, go to Certificates / View Certificates...
• open the "Authorities" tab
• move the mouse pointer over the divider between the "Certificate Name" and "Security Device" columns (the pointer changes to a left-right arrow)
• click and drag the divider

Actual results:

The columns are resized.

Expected results:

Nothing happens.

Comment 1

[David Balažic]

It is the same on all tabs in that setting page, except the "Authentication Decisions", where the pointer does not even change shape to the left-right arrow form.

Impact: if data in table is longer than column width, it can not be read. Like the serial numbers of certificates.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Security: PSM' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1822578, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861349 - Allow resizing certManager columns. r=#settings

See also bug 1821404.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5793f210c595
Allow resizing certManager columns. r=settings-reviewers,Gijs

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5793f210c595

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9360584 [details]
Bug 1861349 - Allow resizing certManager columns. r=#settings

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivialish css change.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9360584 [details]
Bug 1861349 - Allow resizing certManager columns. r=#settings

Approved for 120.0b5

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6df364abb481

Comment 12

[Hani Yacoub, Desktop QA]

Attachment: Screen Recording 2023-11-01 at 16.39.11.mov

I verified that the column can be resized on macOS 11.6, Ubuntu 20.04 and on Windows 11 x64 on both Firefox 121.0a1 (2023-11-01) and on Firefox 120.0b5.
But I observed that this fix introduced another bug, the certificate managed is also resized after resizing the columns and confirming it.
Please see the screen recorder attached.
Should I log a separate issue for this and confirm this bug only on the column resize?
Thanks.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Hah, nice catch. I guess let's back out of beta then, and I can fix that issue on Nightly. Yeah, please file a bug for that and needinfo me.

Diana can you back out of beta? Thanks!

Comment 14

[Dianna Smith [:diannaS]]

sure, done!
Backed out for 120.0b6 for causing new issue (:hani please attach regression to this ticket when you get a chance)

Backout link: https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=661ffaa432e4cc863263a07b7bdd27795a5df836

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6c003ea8ca11

Comment 16

[Hani Yacoub, Desktop QA]

Marking the bug as verified on Nightly since the fix was backed out from Beta and a new bug was logged.
Thanks.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Seems like a useful fix for enterprise users. Please nominate this and bug 1862599 for ESR115 approval if you agree. They graft cleanly.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9360584 [details]
Bug 1861349 - Allow resizing certManager columns. r=#settings

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: comment 0
• User impact if declined: comment 0
• Fix Landed on Version: 121
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple css fix. Needs also bug 1862599 comment 7.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9360584 [details]
Bug 1861349 - Allow resizing certManager columns. r=#settings

Approved for 115.6esr.

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/fce67958ff6e

Comment 21

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 11.6 and Ubuntu 20.04 x64.