1861400 - Remove sync if disabled by policy

Status: RESOLVED FIXED

(Firefox :: Firefox View, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

I think we made the wrong decision with the new view for the summary page as it relates to policy.

It makes sense to show the "disabled by policy" on the sync page itself, but having a big useless area on the summary page when sync is disabled is kind of annoying (per feedback from users).

I think we should just now show the sync section on summary if disabled by policy (and probably not show the entry on the left either)

Comment 1

[Sarah Clements [:sclements]]

(In reply to Mike Kaply [:mkaply] from comment #0)

I think we made the wrong decision with the new view for the summary page as it relates to policy.

It makes sense to show the "disabled by policy" on the sync page itself, but having a big useless area on the summary page when sync is disabled is kind of annoying (per feedback from users).

I think we should just now show the sync section on summary if disabled by policy (and probably not show the entry on the left either)

By summary page you mean Recent Browsing? Perhaps not showing it on the recent browsing page if its been disabled by an admin is fine, but I don't think we should remove it entirely on the left side navigation. Users might think its a bug that they can't see open tabs on a specific device. epang, what do you think?

Also, note that the user feedback Mike is referring to was on another bug here.

Comment 2

[Mike Kaply [:mkaply]]

Yeah, I'm thinking mainly from the summary page main area, and I was torn on the left side, but I agree that's on UX to decide.

Comment 3

[Sarah Clements [:sclements]]

Maybe a dismissable banner for this scenerio would make sense. Tell the user once why they can't have synced tabs, but then its not build into that container so they always see it.

Comment 4

[Eric Pang [:epang] UX]

(In reply to Sarah Clements [:sclements] from comment #1)

(In reply to Mike Kaply [:mkaply] from comment #0)

I think we made the wrong decision with the new view for the summary page as it relates to policy.

It makes sense to show the "disabled by policy" on the sync page itself, but having a big useless area on the summary page when sync is disabled is kind of annoying (per feedback from users).

I think we should just now show the sync section on summary if disabled by policy (and probably not show the entry on the left either)

By summary page you mean Recent Browsing? Perhaps not showing it on the recent browsing page if its been disabled by an admin is fine, but I don't think we should remove it entirely on the left side navigation. Users might think its a bug that they can't see open tabs on a specific device. epang, what do you think?

Also, note that the user feedback Mike is referring to was on another bug here.

This makes sense to me and we kind of saw this coming when we originally designed it with an "x" in the corner for recent browsing so that it could be closed out (not just for the disabled policy use case). But now that we have the section with the dropd own it kind of feels odd to be able to remove an entire section. Makes more sense to be able to close the banner/message, but they you're left with an empty drop down.

For this use case I agree that we shouldn't show it on recent browsing page but should keep the section in the left hand nav and display the message in the section itself. Having the information int he section itself should be enough if the user goes looking for why it isn't working. Thanks!

Comment 6

[Sarah Clements [:sclements]]

This could cover the case when enterprise users disable identity.fxaccounts.enabled, since that just prompts users to show synced tabs - see bug 1884570.

Comment 7

[Mike Kaply [:mkaply]]

Yeah, I think we use that pref in policy. I should have just implemented this when I opened it

Comment 8

[Sarah Clements [:sclements]]

It looks like we already remove any trace of sync in the hamburger menu and sidebar when this pref is disabled, so we should do this work sooner than later.

I thought there was two different prefs (one for sync and one for fax specifically) but it seems its just this one, though its worth double-checking: https://searchfox.org/mozilla-central/source/browser/components/firefoxview/firefox-view-synced-tabs-error-handler.sys.mjs#38

Comment 9

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1861400 - Remove sync if disabled by policy r?#fxview-reviewers!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d60f4b71384
Remove sync if disabled by policy r=fxview-reviewers,nsharpley,kcochrane

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3d60f4b71384