Open
Bug 1861505
Opened 1 year ago
Updated 3 months ago
Replace --in-content-button variables with button Design Tokens
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
ASSIGNED
People
(Reporter: mstriemer, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(1 file)
Once we have the --in-content-button-*
variables being defined from the tokens in bug 1835869 then the existing uses of --in-content-button-*
variables can be replaced with our --button-*
Design Token variables
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Depends on D188123
Updated•1 year ago
|
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Updated•1 year ago
|
Blocks: design-tokens-migration
Updated•1 year ago
|
Whiteboard: [fidefe-reusable-components] → [recomp]
Assignee | ||
Comment 3•3 months ago
|
||
I used this script to rename the variables before, could be useful again
- Download the two files
cat in-content-button-renames.txt | xargs -I % sh -c 'bash rename-css-var.sh %'
- Remove or verify the assignments that were updated
** This can probably be removed:--button-text-color: var(--in-content-text-color);
** This can definitely be removed:--button-background-color: color-mix(in srgb, currentColor 7%, transparent);
** Unsure here, probably fine but maybe worth refactoring the styles (blockedSite.css):--button-background-color: transparent;
You need to log in
before you can comment on or make changes to this bug.
Description
•