Open Bug 1861505 Opened 1 year ago Updated 3 months ago

Replace --in-content-button variables with button Design Tokens

Categories

(Toolkit :: Themes, task)

task

Tracking

()

ASSIGNED

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

Once we have the --in-content-button-* variables being defined from the tokens in bug 1835869 then the existing uses of --in-content-button-* variables can be replaced with our --button-* Design Token variables

Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Whiteboard: [fidefe-reusable-components] → [recomp]

This doesn't depend on bug 1835869 anymore.

No longer depends on: 1835869

I used this script to rename the variables before, could be useful again

  1. Download the two files
  2. cat in-content-button-renames.txt | xargs -I % sh -c 'bash rename-css-var.sh %'
  3. Remove or verify the assignments that were updated
    ** This can probably be removed: --button-text-color: var(--in-content-text-color);
    ** This can definitely be removed: --button-background-color: color-mix(in srgb, currentColor 7%, transparent);
    ** Unsure here, probably fine but maybe worth refactoring the styles (blockedSite.css): --button-background-color: transparent;
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: