1861505 - Replace --in-content-button variables with button Design Tokens

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Mark Striemer [:mstriemer]]

Once we have the --in-content-button-* variables being defined from the tokens in bug 1835869 then the existing uses of --in-content-button-* variables can be replaced with our --button-* Design Token variables

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1861505 - Remove --in-content-button* variables r?#desktop-theme-reviewers

Depends on D188123

Comment 2

[Dão Gottwald [:dao]]

This doesn't depend on bug 1835869 anymore.

Comment 3

[Mark Striemer [:mstriemer]]

I used this script to rename the variables before, could be useful again

1. Download the two files
2. cat in-content-button-renames.txt | xargs -I % sh -c 'bash rename-css-var.sh %'
3. Remove or verify the assignments that were updated
   ** This can probably be removed: --button-text-color: var(--in-content-text-color);
   ** This can definitely be removed: --button-background-color: color-mix(in srgb, currentColor 7%, transparent);
   ** Unsure here, probably fine but maybe worth refactoring the styles (blockedSite.css): --button-background-color: transparent;

Comment 4

[Catherine Meade]

Attachment: Bug 1861505 - Remove --in-content-button-* variables r?#reusable-components-reviewers

Changed

• references to--in-content-button-* custom properties now use --button-* counterparts

Removed

• --in-content-button-text-color
• --in-content-button-text-color-hover
• --in-content-button-text-color-active
• --in-content-button-background
• --in-content-button-background-hover
• --in-content-button-background-active
• --in-content-button-border-color
• --in-content-button-border-color-hover
• --in-content-button-border-color-active
• --in-content-primary-button-text-color
• --in-content-primary-button-text-color-hover
• --in-content-primary-button-text-color-active
• --in-content-primary-button-background
• --in-content-primary-button-background-hover
• --in-content-primary-button-background-active
• --in-content-primary-button-border-color
• --in-content-primary-button-border-hover
• --in-content-primary-button-border-active
• --in-content-danger-button-background
• --in-content-danger-button-background-hover
• --in-content-danger-button-background-active

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c09fa0bd13b4
https://hg.mozilla.org/integration/autoland/rev/6500873b42b5
Remove --in-content-button-* variables r=reusable-components-reviewers,mtigley,extension-reviewers,settings-reviewers,desktop-theme-reviewers,credential-management-reviewers,webrtc-reviewers,devtools-reviewers,fxview-reviewers,omc-reviewers,nsharpley,hjones,ng,aminomancer,rpl

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6500873b42b5