1861626 - Use rtoml instead of toml to read test manifests

Status: NEW

(Firefox Build System :: Task Configuration, enhancement)

Description

[Marco Castelluccio [:marco]]

Not sure how faster it is, but it's worth investigating.

Comment 1

[Mike Hommey [:glandium]]

rtoml is a compiled module, that makes it significantly harder to deploy. (even more so for decision tasks)

Comment 2

[Mike Hommey [:glandium]]

(also, the switch from tomlkit to toml didn't really impact decision task times, despite having had a dramatic effect on configure)

Comment 3

[Marco Castelluccio [:marco]]

Time to read 7777 manifests:

import timeit
import toml
import tomlkit
import tomllib
import rtoml

with open("browser/base/content/test/popups/browser.toml", "r") as f:
    manifest = f.read()

def parsewithtoml():
    toml.loads(manifest)

def parsewithtomlkit():
    tomlkit.parse(manifest)

def parsewithtomllib():
    tomllib.loads(manifest)

def parsewithrtoml():
    rtoml.load(manifest)

print(timeit.timeit('parsewithtoml()', number=7777, globals=globals()))
print(timeit.timeit('parsewithtomlkit()', number=7777, globals=globals()))
print(timeit.timeit('parsewithtomllib()', number=7777, globals=globals()))
print(timeit.timeit('parsewithrtoml()', number=7777, globals=globals()))

toml 4.716776925000886
tomlkit 70.1370183600011
tomllib 2.5913682589998643
rtoml 0.6805894560020533