1949143 - Too much time is spent reading test manifests during configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Florian Quèze [:florian]]

See this profile filtered on "testmanifest" https://share.firefox.dev/3EGAuga showing 892 samples (so at least 892ms). Filtering for "toml" shows 699 samples (https://share.firefox.dev/40XnWII).

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1949143 - Use tomllib instead of toml for faster parsing during configure r=florian!

tomllib is part of the standard library since python 3.11 and parses
toml faster then the third-party toml package.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa3fe5e40307
Use tomllib instead of toml for faster parsing during configure r=jmaher

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/aa3fe5e40307

Comment 4

[Marco Castelluccio [:marco]]

Since we're still on Python 3.8 for builds on CI, this only benefitted local builds.

I wonder: could we integrate rtoml, which is even faster than tomllib, and use it both in CI and for local builds? See bug 1861626.