Closed Bug 1861841 Opened 2 years ago Closed 2 years ago

Update SeaMonkey website for 2.53.18 beta 1 release

Categories

(SeaMonkey :: Website, task)

Production

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.18)

Attachments

(2 files, 3 obsolete files)

The usual. Add news download section and release notes.

Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attached patch 1861841-25318b1.patch (obsolete) — Splinter Review

We added a ton of other stuff but mostly minor and nothing for the realese notes I think.

Attachment #9363120 - Flags: review?(nunojsg)
Attachment #9363120 - Flags: review?(iannbugzilla)

I found some Typos:

compatiblity  →   
compatibility

Indentify  →   
Identify 
   (?)

Crash reporting bas been switched over to  →   
Crash reporting has been switched over to

Fixes for main patch. Not for checkin but later folding into main patch after review / possible additional changes.

Comment on attachment 9363120 [details] [diff] [review] 1861841-25318b1.patch >+++ b/src/news.en.xml Need to change showfront="true" to "false" for the 2.53.17 and 2.53.17 Beta 1 releases r=me with that fixed
Attachment #9363120 - Flags: review?(iannbugzilla) → review+

Comment on attachment 9363120 [details] [diff] [review]
1861841-25318b1.patch

In src/releases/index.en.html, the commented out entry added to the #old div, for this release, reads "2.53.17 Beta 1" (and links to that one), should probably be '<a href="2.53.18b1">2.53.18 Beta 1</a>'?

The patches look good with this and #c4 covered.

Attachment #9363120 - Flags: review?(nunojsg) → review+
Attached patch 1861841-v1_1-25318b1.patch (obsolete) — Splinter Review

Updated patch. r+ carried forward

Attachment #9363120 - Attachment is obsolete: true
Attachment #9363165 - Attachment is obsolete: true
Attachment #9363178 - Flags: review+

Upps. forgot the showfront ones. r+ carried forward.

Attachment #9363178 - Attachment is obsolete: true
Attachment #9363179 - Flags: review+

There are some broken links on https://www.seamonkey-project.org/releases/2.53.18b1:

If I'm understanding correctly, the "Release Notes" link is assembled using relnoteversion, which was set to 2.53.18b1. This is an untested patch to remove the "b1".

The "Document History" link leads to an error message because this bug's website change hasn't reached the repository at hg.mozilla.org yet, and so the corresponding source file does not exist there.

Attachment #9363602 - Flags: review?(iannbugzilla)
Attachment #9363602 - Flags: review?(frgrahl)

Comment on attachment 9363602 [details] [diff] [review]
1861841-relnoteversion

Looks like I manage to bumble at least one version string with every patch :) Will check it in tomorrow. Was a long day. Thanks

Attachment #9363602 - Flags: review?(iannbugzilla)
Attachment #9363602 - Flags: review?(frgrahl)
Attachment #9363602 - Flags: review+
Blocks: 1867974
Blocks: 1902848
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: