1861886 - POP3: When downloading headers only, the option "Close message window/tab on move or delete" causes the window/tab to be closed when "Download the rest of the message" is clicked

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[betterbird.project+11]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36 Edg/118.0.2088.76

Steps to reproduce:

POP3: When downloading headers only, the option "Close message window/tab on move or delete" causes the window/tab to be closed when "Download the rest of the message" is clicked:

STR:
Select option: "Close message window/tab on move or delete"
Select POP3 account option to download headers only.
Open message in windows/tab and click "Download the rest of the message".

Actual results:

Closes windows/tab.

Expected results:

Should download message and show it in window/tab.

Works in 102, seems to be caused by Supernova.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1861886 - Don't notify of header deletion when completing POP3 messages. r=mkmelin

Comment 2

[betterbird.project+11]

Thanks for the fix. It fixes the reported problem, but it breaks the message list. The original message is doubled up and when clicking the two messages, one turns into a message with empty subject and date "1 Jan 1970". This looks very weird. We think that the fix shouldn't be made in the backend but rather the frontend shouldn't close the message window/tab when getting the rest of the message.

Comment 3

[betterbird.project+11]

102 tracked a _deleteInProgress:
https://searchfox.org/comm-esr102/rev/e93a5d1c08d70a159a04d1b8cb1e31953889616c/mail/base/content/messageDisplay.js#559
https://searchfox.org/comm-esr102/rev/e93a5d1c08d70a159a04d1b8cb1e31953889616c/mail/base/content/messageWindow.js#307
This was set in hintAboutToDeleteMessages() which was called in all the functions that led to "real" message deletion:
https://searchfox.org/comm-esr102/search?q=hintAboutToDeleteMessages&redirect=false

Now the window/tab is just closed even for "non delete" actions which trigger onMessagesRemoved():
https://searchfox.org/comm-central/rev/532e9eceb50e249c9ed0ba447ece29e50fb62846/mail/base/content/mailCommon.js#1075

One way to fix the bug would be to track "real" deletions again and not to close the window/tab for "non delete" removals. A more hacky solution would be to temporarily clear the pref for the call of DeleteHeader():
https://searchfox.org/comm-central/rev/532e9eceb50e249c9ed0ba447ece29e50fb62846/mailnews/local/src/nsPop3Sink.cpp#633

Comment 4

[betterbird.project+11]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1861886-dont-close-on-get-rest-of-message-bb.patch
(even more hacky since the pref can't be cleared "temporarily" from C++)

Comment 5

[Magnus Melin [:mkmelin]]

Perhaps we should just ignore closing for Ci.nsMsgMessageFlags.Partial?

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1861886 - Don't close tab/window when completing POP3 message. r=mkmelin

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1861886 - Don't close tab/window when completing POP3 message. r=mkmelin

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1861886 - Don't close tab/window when completing POP3 message. r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d53755719d2b
Don't close tab/window when completing POP3 message. r=mkmelin

Comment 10

[Wayne Mery (:wsmwk)]

good for 115?

Comment 11

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9368059 [details]
Bug 1861886 - Don't close tab/window when completing POP3 message. r=mkmelin

[Approval Request Comment]
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9368059 [details]
Bug 1861886 - Don't close tab/window when completing POP3 message. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 115.7.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6fa66d762c84