1862135 - _getCoherenceStatements should update moz_places_metadata when deduping urls

Status: NEW

(Toolkit :: Places, defect, P3)

Description

[Masatoshi Kimura [:emk]]

It does not take care of new tables added after bug 1422058.

• moz_historyvisits_extra and moz_places_extra (bug 1841866)
• moz_meta (bug 1426554)
• moz_places_metadata and moz_places_metadata_search_queries (bug 1713073)
• moz_previews_tombstones (bug 1742558)

Comment 1

[Mark Banner (:standard8)]

Please can you detail what you think is missing here? Or examples of what data is being left in tables when it shouldn't be?

For example, moz_places_extra has a 1:1 mapping with moz_places and will automatically delete any entry when it is deleted from moz_places: https://searchfox.org/mozilla-central/rev/eadfec923e2b9c927ade8d0dd4f08a82da50a8a9/toolkit/components/places/nsPlacesTables.h#52-58

There's something similar in place for moz_historyvisits_extra as well.

Hence, I'm not sure why we would need to add them to _getCoherenceStatements.

Comment 2

[Masatoshi Kimura [:emk]]

Oh, you are right about moz_places_extra and moz_historyvisits_extra. moz_meta, moz_places_metadata_search_queries and moz_previews_tombstones also look good.

But moz_places_metadata has n:1 mappings with moz_places. So FKs will need update when dupliate URLs are removed from moz_places (step L.1).

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Marco Bonardo [:mak]]

I think the likelihood of adding duped urls is extremely low today, this maintenance was likely to help in the past because we had some bugs potentially adding dupes. Thus I agree it should be fixed, but not a top priority.