1862232 - Customizable toolbar: "Reply to List" is always disabled after 115.4.1 upgrade

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Lucien Gentis]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I wanted to use "Reply to list" button from customizable toolbar, but item is grey tinted. (it is unreachable).
(see attachment)

Actual results:

Items in customizable toolbar are unreachable (grey tinted) since last Thunderbird update (version 115.4.1 (64-bit))

Expected results:

I habitually use these items to answer messages without problem.
I tried to disable items by clicking "Personnalize", and then to enable them again, without success.
I precise that it is possible to use "Reply to list" item by right clicking on a message and choosing this item in popup menu.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

I can confirm this for "Reply to List." Is "Reply to" really unreachable as well?

Comment 2

[Lucien Gentis]

No, you're right, only "Reply to List." is unreachable.
"Reply to" and "Reply to All" are unreachable ... when no message is selected, which is normal behavior.
Apologize.
Lucien

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1862232 - Add a special "Reply to List" button to unified toolbar. r=#thunderbird-front-end-reviewers

Checking if "Reply to List" should be enabled doesn't work until the headers of the current
message have been processed. This implements class ReplyListButton that listens for the "MsgLoaded"
event to set its state.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3c504ca560a
Add a special "Reply to List" button to unified toolbar. r=freaktechnik

Comment 5

[Geoff Lankow (:darktrojan) [PTO, back 2 Nov]]

Attachment: Bug 1862232 - Fix a broken test. r=#thunderbird-reviewers

nsIMsgDBView.URIForFirstSelectedMessage throws an exception when there is no selected message.
Although numSelectedMessages is 1, we're looking at a message loaded from a file so there are
no messages to select. (It's always 1 when we're in a message tab or message window.)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1d7a6a7d6383
Fix a broken test. r=mkmelin

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9361428 [details]
Bug 1862232 - Add a special "Reply to List" button to unified toolbar. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1851971
User impact if declined: "Reply to List" button in customizable toolbar isn't usable
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9361547 [details]
Bug 1862232 - Fix a broken test. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1851971
User impact if declined: "Reply to List" button in customizable toolbar isn't usable
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9361428 [details]
Bug 1862232 - Add a special "Reply to List" button to unified toolbar. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9361547 [details]
Bug 1862232 - Fix a broken test. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/ed90c34cb484
https://hg.mozilla.org/releases/comm-esr115/rev/ae61c2adaaba

Comment 12

[Lucien Gentis]

Thanks to all for having fixed this bug.
Regards
Lucien