1862399 - Hoist settings and info card expand states into the feature state

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P2)

Description

[Rahul Sainani [:rsainani]]

Steps to reproduce

1. Ensure shopping experience is on
2. Visit a product page that doesn't have the analysis yet or has a stale analysis.
3. Expand the settings and info card
4. Click analyze
5. Wait for analysis to complete and observer the states of settings and info cards.

Expected behavior

The cards should remain expanded.

Actual behavior

The cards get collapsed/reset when the state transitions.

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

This can be solved by hoisting the each card expanded state to the screen state.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1862399 - Keep review checker card expanded states in ReviewQualityCheckState (#4317)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/a7c94bef17eef516f3bb303f785376067842dd4f
[main] Bug 1862399 - Keep review checker card expanded states in ReviewQualityCheckState

Comment 3

[Rahul Sainani [:rsainani]]

Note for QE: We removed secret settings to fix a nimbus config issue, you might have to use nimbus cli to switch on shopping experience on nightly, till we figure out a better way to replace secret settings. Sorry about the inconvenience!

Comment 4

[Adina Petridean]

Attachment: expand.mov

Comment 5

[Adina Petridean]

Verified as fixed on Nightly 121.0a1 from 11/03 with Motorola Moto G9 plus (Android 11) and Sony Xperia (Android 6.0.1).