1859984 - [meta] Investigate review checker recompositions

Status: NEW

(Fenix :: Shopping, task, P2)

Description

[Rahul Sainani [:rsainani]]

When product analysis changes, the "whole" sheet recomposes instead of just individual card(s) who's data has changed. Investigate why this happens and create a solution.

This is important for following (non exhaustive) reasons:

1. Improved performance as UI is redrawing less.
2. Consistent UI state for the users, currently displaying the product recommendation will recompose/redraw many other unrelated cards and won't save their state, as a result you might notice some expanded cards might collapse when product recommendation is loaded.

Comment 1

[Noah Bond [:007]]

Just discovered this meta. I think this is what's causing the animation issue over in Bug 1858020, but I'm still investigating the recomposition issues I'm seeing

Comment 2

[Noah Bond [:007]]

Investigation notes 11/8/23

• The Crossfade is the culprit and causing multiple recomps
• Expanding either settings or grade info causes a recomp here
• Triggering a recomp with Crossfade will re-render the to AND from content blocks?
• The animation bug is still there even after finding an optimization for the Crossfade AND commenting out the Loading UI
• Based on the docs for Crossfade, the "from" content kinda gets recomposed to perform the transition, hence why it shows two recomps with one state transition

Investigation branch