Consider adding @Immutabe annotation on AnalysisPresent
Categories
(Fenix :: Shopping, task, P2)
Tracking
(firefox121 fixed)
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: rsainani, Assigned: rsainani)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Since AnalysisPresent uses java collections Apis (List and Set) which are mutable, compose compiler needs extra guidance from the users to understand that this object is indeed immutable.
Follow the the stability docs to diagnose and fix this issue. In the compiler reports, functions that uses this object are marked as non-skippable (aka it will always be composed even if highlights do not change) and AnalysisPresent is marked as unstable
After adding Immutable, notice that this object will be marked as stable and composables using this object directly will be marked skippable.
Note that this is not the ideal fix, but a step towards reducing recompositions. The better fix is suggested in Bug 1862401
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Updated•1 year ago
|
|
||
Comment 1•1 year ago
|
||
|
|
||
Comment 2•1 year ago
|
||
Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/95d53354552105f17815b34a3051878089cd52f1
[main] Bug 1862402 - Mark AnalysisPresent as Immutable for compose compiler
|
|
Assignee | |
Updated•1 year ago
|
Description
•