1862403 - Remove unneeded states from RecommendedProductState like Loading and Error.

Status: VERIFIED FIXED

(Fenix :: Shopping, task, P2)

Description

[Rahul Sainani [:rsainani]]

Currently it contains 4 states - Initial, Loading, Error and Product. This is correct however the UI only uses 2 states and doesn't plan to use the other states. It would be ideal to have only 2 states or use nullable Product to model the RecommendedProductState.

This also has the good side effect of reducing recompositions since there are no unwanted state changes.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1862403 - Remove unneeded states from RecommendedProductState (#4381)

Comment 2

[BMO Github Automation]

Authored by https://github.com/RebecaTudor
https://github.com/mozilla-mobile/firefox-android/commit/abc96a424161aab70c1c5143e0b3d67e4857553f
[main] Bug 1862403 - Remove unneeded states from RecommendedProductState

Comment 3

[Rebeca Tudor]

After these changes the behavior shouldn't be changed.

The expected behavior:
Setup:

• Shopping experience is enabled
• Review Checker is opted in
• The setting from Review Checker for Product Recommendation is enabled

When you are on a product page from a supported retailers like this, tap on the tags and in Review Checker, a product should be showed.

Comment 4

[miralobontiu]

Verified on the latest Nightly 121.0a1 with Google Pixel 6 (Android 14), and Oppo Find N2 Flip (Android 13).

I've tested this, by enabling the Android Nightly experiment (in PREVIEW mode only) for Fakespot ads: https://experimenter.services.mozilla.com/nimbus/android-review-checker-smoke-test-with-promos/summary, by using Nightly's secret settings to manually enroll in this preview experiment.

I've turned ON the "Show ads in review checker" switch, reload the shopping product page (standing desk product), and observed the "More to consider" area that displayed a link to a similar product/recommended prodyct. I've tapped the link was redirected to the recommended product page.