1862438 - Uplift Request form fields disappear on refresh

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect, P3)

Description

[Dianna Smith [:diannaS]]

Attachment: Screenshot 1.png

fyi: Seems minor now that I can recreate the issue

STR:
Go to a Phab Patch that already is requested for uplift
Add action to "Change uplift request form
(Notice all the fields appear)
Refresh browser
(Notice some fields disappear) (see screenshot 1)
Refresh again
(Notice more fields disappear) (see screenshot 2)

After the first refresh you will not be able to edit the request form because a validation for missing fields will stop you from editing. (see screenshot 3)

Comment 1

[Dianna Smith [:diannaS]]

Attachment: Screenshot 2.png

Comment 2

[Dianna Smith [:diannaS]]

Attachment: Screenshot 3.png

Comment 4

[Daniel Holbert [:dholbert]]

FWIW this doesn't just affect refresh; that just happens to be the easiest way to trigger it on-demand.

It also affects the perhaps-more-realistic flow of
(1) begin filling out ESR uplift request, but don't complete it (maybe you realize you need to gather some more information)
(2) close tab, knowing that phabricator saves your partially-entered information
(3) later on, navigate back to that phabricator page, to finish your ESR uplift request.
(4) Attempt to complete your partially-completed uplift-request-form, but notice that some fields are missing. In fact phabricator won't let you submit, since values are required for those fields that phabricator is not showing you.

(I ran into this yesterday with these STR)

Comment 5

[Dianna Smith [:diannaS]]

Putting workaround from duplicate here for easier reference to those affected.

WORKAROUND:
Once you're in this state, the only way I've found to recover (to get back to a form that you're actually able to submit) is:
(a) Save a copy of any text that you want to preserve from the fields that you've filled out and can still see.
(b) Click the "x" at the upper-right of the uplift request form
(c) Reload the page
(d) Choose "Add Action | Change Uplift Request Form"
(e) Copypaste back your content that you had saved in (a), and fill out and submit the whole form now before you inadvertently reload (or equivalent e.g. restarting Firefox) and trigger this bug again.

Comment 6

[Luke Crouch [:groovecoder]]

Bump. I hit this today and had to use the work-around. Someone else also hit it 4 days ago.

Comment 7

[Dão Gottwald [:dao]]

I hit this today as well, was pretty annoying and cost me substantial time.

Comment 8

[Connor Sheehan [:sheehan]]

Bug 1987196 has just landed and is being deployed, after which the Phabricator uplift request assessment form will be removed.

Please use the new form in Lando, which does not have these issues.