1862556 - Add the ability to create LongTask profiler markers for any thread

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

It's frequently useful to be able to see if any events on thread are taking an inordinate amount of time. Right now we have LongTask markers on MainThread (and jank markers), but LongTask markers are only for >50ms and only for MainThread.

The design I came up with uses the existing option structure to NS_NewNamedThread() to turn on LongTask markers, and to set how long is 'long'.

For non-mainthread, since many use customized event loops like SocketThread's calls to Poll, I stop the NestedEventLoop code from inserting markers.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1862556: Allow LongTask markers to be generated for any nsThread r=nika!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2573ea9f377b
Allow LongTask markers to be generated for any nsThread r=nika

Comment 3

[Cristian Tuns]

Backed out for causing build bustages in nsThreadManager.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:313:75: error: no matching function for call to 'nsThread::nsThread(mozilla::NotNull<RefPtr<mozilla::ThreadEventQueue> >, nsThread::MainThreadFlag, <brace-enclosed initializer list>)'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e65eec5eb5e
Allow LongTask markers to be generated for any nsThread r=nika

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6e65eec5eb5e