Closed Bug 1862557 Opened 2 years ago Closed 2 years ago

Add profiler LongTask markers for SocketTransportService/Socket Thread

Categories

(Core :: Networking, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Note due to the Poll usage we have to add a second marker injection to record time spent calling OnSocketReady() for any woken-up sockets.

Includes separate markers for OnSocketReady() calls after Poll()

Severity: -- → N/A
Priority: -- → P3
Whiteboard: [necko-triaged]
Pushed by rjesup@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ef47a21279a Add LongTask profiler marker generation to SocketThread r=necko-reviewers,kershaw

Backed out for causing build bustages in nsThreadManager.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:313:75: error: no matching function for call to 'nsThread::nsThread(mozilla::NotNull<RefPtr<mozilla::ThreadEventQueue> >, nsThread::MainThreadFlag, <brace-enclosed initializer list>)'
Flags: needinfo?(rjesup)
Pushed by rjesup@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93a04e8835aa Add LongTask profiler marker generation to SocketThread r=necko-reviewers,kershaw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Flags: needinfo?(rjesup)
Regressions: 1868959
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: