Closed Bug 1862674 Opened 7 months ago Closed 6 months ago

copy paste image from other email is blocked

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 115
defect

Tracking

(thunderbird_esr115 fixed, thunderbird121 fixed)

RESOLVED FIXED
122 Branch
Tracking Status
thunderbird_esr115 --- fixed
thunderbird121 --- fixed

People

(Reporter: paul, Assigned: mkmelin)

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1367716 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce:

Composed email messages including image files from local hard drives is now blocked as of version 52.

Actual results:

The message "Thunderbird has blocked a file from loading into this message." appears on screen, so you have to unblock individual images each time you create a new message.

Expected results:

Add an advanced option to the "Thunderbird has blocked a file from loading in this message..." to permanently unblock "file:///"

Ok this has popped up in 115.x.x as of late, was ok in the 110.x.x branch

and really needs to be addressed

in my case it is blocking imap:// addresses

if you do not want to fix this then when i copy a picture to the clipboard then copy the image properly where it can be pasted into the message editor without the warning ?

like the threaded view defaulting to sorted this is an annoyance to click the yellow allow bar every time i copy a picture from a thunderbird email into a new email

I do a lot of tech support and this gets in the way 100+ times a day

yes the allow remote content is enabled?

Sorry, that was disallowed for good reason.
Direct access to other imap messages is blocked by design.

Status: UNCONFIRMED → RESOLVED
Closed: 7 months ago
Resolution: --- → WONTFIX

then please advise how to copy a graphic sent on one email to a new email ?

since the received email with the graphic has already passed any security issues, why would it be blocked copying it into a new email ?

Copying from another email should work.
Something about this seems to have broken after 102 (where it works as it should).

Are you able to find a regression range? You can use https://mozilla.github.io/mozregression/

Status: RESOLVED → REOPENED
Component: Security → Message Compose Window
Ever confirmed: true
Resolution: WONTFIX → ---
Summary: Add advanced option to unblock local image files when composing → copy paste image from other email is blocked
Status: REOPENED → NEW

Appears to be Supernova damage, this code may no longer be in the right spot:
https://searchfox.org/comm-central/rev/2b973b5093cdbd08e0d313c38d9cc51c763698da/mail/base/content/mailWindow.js#67

Need to use our own copy handling.
Use goCopyImage() to copy the image data instead of internal urls

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1862674-fix-copy-paste-img.patch

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED

There is a possible simplification: goDoCommand("cmd_copyImageContents") appears to do the same as the code in goCopyImage(), so the latter might be retired in favour of the former. We didn't investigate this further and didn't opt for this change to keep the code changes to a minimum.

Attachment #9363657 - Attachment description: Bug 1862674 - Fix copy/paste image from one message into another. r=#thunderbird-reviewers → Bug 1862674 - Fix copy/paste image from one message into another. r=aleca
Target Milestone: --- → 122 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/374c2bbd4034
Fix copy/paste image from one message into another. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 7 months ago6 months ago
Resolution: --- → FIXED

thanks

please advise where i can download the update ?

It's still only available in daily. Will uplift to releases soon. You'll see activity in this bug.

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: can't copy paste image from one message into another (easily)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): pretty safe

Attachment #9363657 - Flags: approval-comm-esr115?
Attachment #9363657 - Flags: approval-comm-beta?

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Triage Comment]
Approved for beta

Attachment #9363657 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Triage Comment]
Approved for esr115

Attachment #9363657 - Flags: approval-comm-esr115? → approval-comm-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: