1862674 - copy paste image from other email is blocked

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[[e-mail]]

+++ This bug was initially created as a clone of Bug #1367716 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce:

Composed email messages including image files from local hard drives is now blocked as of version 52.

Actual results:

The message "Thunderbird has blocked a file from loading into this message." appears on screen, so you have to unblock individual images each time you create a new message.

Expected results:

Add an advanced option to the "Thunderbird has blocked a file from loading in this message..." to permanently unblock "file:///"

Ok this has popped up in 115.x.x as of late, was ok in the 110.x.x branch

and really needs to be addressed

in my case it is blocking imap:// addresses

if you do not want to fix this then when i copy a picture to the clipboard then copy the image properly where it can be pasted into the message editor without the warning ?

like the threaded view defaulting to sorted this is an annoyance to click the yellow allow bar every time i copy a picture from a thunderbird email into a new email

I do a lot of tech support and this gets in the way 100+ times a day

yes the allow remote content is enabled?

Comment 1

[Magnus Melin [:mkmelin]]

Sorry, that was disallowed for good reason.
Direct access to other imap messages is blocked by design.

Comment 2

[[e-mail]]

then please advise how to copy a graphic sent on one email to a new email ?

since the received email with the graphic has already passed any security issues, why would it be blocked copying it into a new email ?

Comment 3

[Magnus Melin [:mkmelin]]

Copying from another email should work.
Something about this seems to have broken after 102 (where it works as it should).

Are you able to find a regression range? You can use https://mozilla.github.io/mozregression/

Comment 4

[betterbird.project+11]

Appears to be Supernova damage, this code may no longer be in the right spot:
https://searchfox.org/comm-central/rev/2b973b5093cdbd08e0d313c38d9cc51c763698da/mail/base/content/mailWindow.js#67

Comment 5

[betterbird.project+11]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1862674-fix-copy-paste-img.patch, as predicted, plus an additional issue.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

Need to use our own copy handling.
Use goCopyImage() to copy the image data instead of internal urls

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1862674-fix-copy-paste-img.patch

Comment 7

[betterbird.project+12]

There is a possible simplification: goDoCommand("cmd_copyImageContents") appears to do the same as the code in goCopyImage(), so the latter might be retired in favour of the former. We didn't investigate this further and didn't opt for this change to keep the code changes to a minimum.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/374c2bbd4034
Fix copy/paste image from one message into another. r=aleca

Comment 9

[[e-mail]]

thanks

please advise where i can download the update ?

Comment 10

[Magnus Melin [:mkmelin]]

It's still only available in daily. Will uplift to releases soon. You'll see activity in this bug.

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: can't copy paste image from one message into another (easily)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): pretty safe

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Triage Comment]
Approved for beta

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 121.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/27090855968c

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9363657 [details]
Bug 1862674 - Fix copy/paste image from one message into another. r=aleca

[Triage Comment]
Approved for esr115

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/64c41d6995cf