Sync vendored puppeteer to v21.5.2
Categories
(Remote Protocol :: Agent, task, P2)
Tracking
(firefox122 fixed)
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
()
Details
(Whiteboard: [webdriver:m9])
Attachments
(5 files)
Last sync was bug 1851438, and a couple of new tests have been enabled for BiDi since then so it would be nice to do a sync and run those in our CI as well.
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v21.5.0
|
Assignee | |
Updated•10 months ago
|
|
|
Assignee | |
Updated•10 months ago
|
|
|
Assignee | |
Updated•10 months ago
|
|
|
Assignee | |
Comment 1•10 months ago
|
||
Maybe we can also take care of bug 1862069 comment 3 (running npm ci instead of npm install) while doing these vendoring steps.
|
|
Assignee | |
Comment 2•10 months ago
|
||
We should probably wait for a bug fix release of Puppeteer which has the fix for https://github.com/puppeteer/puppeteer/pull/11299 included.
|
|
Assignee | |
Comment 3•10 months ago
|
||
21.5.2 has released last week. Before I have a look at the double click issue lets get this version vendored in.
|
|
Assignee | |
Comment 4•10 months ago
|
||
A first try build without updates to the expectation file:
https://treeherder.mozilla.org/jobs?repo=try&revision=28886fbf49e3b81f84cb8fb67173f4d638ec1cd7
|
|
Assignee | |
Comment 5•10 months ago
|
||
|
||
Updated•10 months ago
|
|
|
Assignee | |
Comment 6•10 months ago
|
||
Here some statistics:
- current: {"suites":242,"tests":1031,"passes":524,"pending":419,"failures":91}
- new: {"suites":248,"tests":1040,"passes":571,"pending":377,"failures":92}
This means we have 9 more tests overall, but 47 more passing tests as before and 42 lesser pending tests.
|
|
Assignee | |
Comment 11•10 months ago
|
||
Something that I do not understand is why the node-progress spinner is adding that many log lines when running the install step for Puppeteer. Here it doesn't matter if I run with npm install or npm ci. This happens locally but also in CI. Bisecting the Puppeteer versions that we skipped shows that this regressed in version 21.3.2. I've filed an issue on the Puppeteer repository: https://github.com/puppeteer/puppeteer/issues/11425.
Maybe we should wait until it has been investigated so that we do not see such a log pollution.
|
|
Assignee | |
Comment 12•10 months ago
|
||
The problem here exists because the environment variable CI is no longer forwarded to the npm command. As it looks like it has been regressed by the changes for bug 1860170. I'll get a new bug filed for a fix.
|
|
Assignee | |
Comment 13•10 months ago
|
||
We should also fix bug 1865678 before the upgrade.
|
|
Assignee | |
Comment 14•10 months ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #12)
The problem here exists because the environment variable
CIis no longer forwarded to thenpmcommand. As it looks like it has been regressed by the changes for bug 1860170. I'll get a new bug filed for a fix.
The problem here is outside of the changes for that bug, and I'll fix it along with the last revision on this stack.
|
||
Comment 15•10 months ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/720eb6933534 [remote] Sync to puppeteer version v21.5.2. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/e6e43da68e60 [puppeteer] Remove -S parameter in Shebang from mocha-runner script because it's not supported in CI. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/664ecf0c5d93 [puppeteer] Update test expectations. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/7630ec582ce9 [remote] Update Puppeteer vendoring documentation. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/d4b82137b5e6 [remote] Update mach command for Puppeteer. r=webdriver-reviewers,Sasha
|
||
Comment 16•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/720eb6933534
https://hg.mozilla.org/mozilla-central/rev/e6e43da68e60
https://hg.mozilla.org/mozilla-central/rev/664ecf0c5d93
https://hg.mozilla.org/mozilla-central/rev/7630ec582ce9
https://hg.mozilla.org/mozilla-central/rev/d4b82137b5e6
Description
•