1863022 - Move Protection Panel Message to calling code

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is move PROTECTION_PANEL message to directly where its inserted inside
browser-siteProtections.js

See https://bugzilla.mozilla.org/show_bug.cgi?id=1724300#c9

This will unblock removing WhatsNewPanel code base and devtool whats new panel test messages from messaging system that's no longer supported

https://bugzilla.mozilla.org/show_bug.cgi?id=1724300

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#66

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1863022 - Render message from browser-siteProtections.js, replace messaging system telemetry, and migrate strings

Comment 2

[Emily McMinn :emcminn]

Romain, do you know who will own the Protections Panel message once it's been moved into browser-siteProtections.js? The folks I know of who worked on it originally aren't around anymore. I'm also curious who I should check in with about the telemetry - in the attached patch I've created a recordEvent ping that kind of duplicates the old Messaging System telemetry, but it required adding some keys to the existing schema and I want to make sure that's OK!

Comment 3

[Romain Testard [:RT]]

Hi Emily, I'm not sure but NIing Tim and Paul who may know.

Comment 4

[Tim Huang[:timhuang]]

Paul is currently the owner of the protection panel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f737edc6cd59
Render message from browser-siteProtections.js, replace messaging system telemetry, and migrate strings r=pdahiya,omc-reviewers,pbz,fluent-reviewers,flod

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_protectionsUI.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/protectionsUI/browser_protectionsUI.js | Test timed out -

Comment 7

[Emily McMinn :emcminn]

I've opted to remove the check for telemetry from the new test added to browser_protectionsUI.js; on top of it being kinda flaky itself, it also had a tendency to cause other tests looking at the telemetry to throw.

I’m also going to revert the use of BrowserTestUtils.waitForMutationCondition back to TestUtils.waitForCondition - some of the failures were caused by that promise hanging and never returning, plus all the other tests in the file use TestUtils.waitForCondition.

I've filed bug 1874024 to cover these, and will try to land the cleaned up patch this afternoon.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bc745cb5371
Render message from browser-siteProtections.js, replace messaging system telemetry, and migrate strings r=pdahiya,omc-reviewers,pbz,fluent-reviewers,flod

Comment 9

[Emma Zühlcke [:emz]]

If you prefer you can also move your test to a separate file. Working around any timeout or intermittent issues with the existing test. Currently looking to reduce failures of this test in another bug.

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2bc745cb5371