1724300 - [Cleanup] Remove code related to What's New panel

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P3)

Description

[Andrei Oprea [:andreio]]

This messaging surface will not be used anymore and the code is making it difficult for other cleanup tasks like bug 1719463.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: WIP: Bug 1724300 - Remove cod related to What's New panel

Comment 2

[Punam Dahiya [:pdahiya]]

As per product , there is possibility to reuse some of the logic of showing previously shown messages, will be good revisit the cleanup in six months

Comment 3

[Vtay]

We can remove this messaging surface. Do note that we might want to reuse some of the logic of showing previously shown messages in the future.

Comment 4

[Punam Dahiya [:pdahiya]]

Removing priority so that it gets picked in next triage

Comment 5

[Negin]

Attachment: WIP: Bug 1724300 - [Cleanup] Remove code related to What's New panel

Comment 6

[Shane Hughes [:aminomancer]]

Is there any plan to show "what's new" messages in the enhanced tracking protection panel in the future? We have some messages on train that appear in the protections panel and use the "what's new" panel code, but whose copy doesn't really seem like a "what's new" message. Should these messages be removed? Or should the relevant code just be refactored to remove references to the "what's new" panel?

Comment 7

[Shane Hughes [:aminomancer]]

This is the message in question. Ed, do you have any thoughts on this? I started removing "what's new" code but it's pretty deeply knotted together with ToolbarPanelHub.jsm, which is necessary for messages like this, which do not seem like "what's new" messages and do not use the What's New panel, but nonetheless share much of the underlying code.

Comment 8

[Ed Lee :Mardak]

The protections panel message is still being shown, and that's what caused the delay / comments in the original patch https://phabricator.services.mozilla.com/D122009#3966384 as it wasn't clear if it needed to still be shown or safe to remove.

Seems like we'll probably need to dig into some metrics of people seeing it and clicking learn more. I suppose if it does want to be kept around, the code specific to this protections panel message could be moved into where it gets inserted:
https://searchfox.org/mozilla-central/rev/4cc23dcad1142ec79256f449a55460215fc75498/browser/base/content/browser-siteProtections.js#1665

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Ed Lee :Mardak from comment #8)

The protections panel message is still being shown, and that's what caused the delay / comments in the original patch https://phabricator.services.mozilla.com/D122009#3966384 as it wasn't clear if it needed to still be shown or safe to remove.

Seems like we'll probably need to dig into some metrics of people seeing it and clicking learn more. I suppose if it does want to be kept around, the code specific to this protections panel message could be moved into where it gets inserted:
https://searchfox.org/mozilla-central/rev/4cc23dcad1142ec79256f449a55460215fc75498/browser/base/content/browser-siteProtections.js#1665

ProtectionPanelMessage was implemented with https://phabricator.services.mozilla.com/D39042. To remove WhatsNewPanel code, a) we should move out ToolbarPanelHub usage in D39042 directly where its inserted inside browser-siteProtections.js b) Use https://phabricator.services.mozilla.com/D122009 patch to remove only WhatsNewPanel codebase leaving ToolbarBadgeHub which needs product buy-in before removal and can be done separately as shown in patch here

Comment 10

[Emily McMinn :emcminn]

Attachment: Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a7df086cc3b
Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4a7df086cc3b