Open Bug 1724300 Opened 2 years ago Updated 9 days ago

[Cleanup] Remove code related to What's New panel

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

Iteration:
111.2 - Jan 30 - Feb 10

People

(Reporter: andreio, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This messaging surface will not be used anymore and the code is making it difficult for other cleanup tasks like bug 1719463.

See Also: → 1724854
Depends on: 1725131
Depends on: 1728582
Priority: P1 → --

As per product , there is possibility to reuse some of the logic of showing previously shown messages, will be good revisit the cleanup in six months

Assignee: andrei.br92 → nobody
Priority: -- → P5

We can remove this messaging surface. Do note that we might want to reuse some of the logic of showing previously shown messages in the future.

Removing priority so that it gets picked in next triage

Priority: P5 → --
Iteration: --- → 109.1 - Nov 14 - Nov 25
Priority: -- → P2
Summary: Remove code related to What's New panel → [Cleanup] Remove code related to What's New panel
Assignee: nobody → nsauermann
Attachment #9304543 - Attachment is obsolete: true
Assignee: nsauermann → nobody
Iteration: 109.1 - Nov 14 - Nov 25 → 109.2 - Nov 28 - Dec 9
Iteration: 109.2 - Nov 28 - Dec 9 → 110.1 - Dec 12 - Dec 23
Iteration: 110.1 - Dec 12 - Dec 23 → 110.2 - Dec 26 - Jan 6

Is there any plan to show "what's new" messages in the enhanced tracking protection panel in the future? We have some messages on train that appear in the protections panel and use the "what's new" panel code, but whose copy doesn't really seem like a "what's new" message. Should these messages be removed? Or should the relevant code just be refactored to remove references to the "what's new" panel?

This is the message in question. Ed, do you have any thoughts on this? I started removing "what's new" code but it's pretty deeply knotted together with ToolbarPanelHub.jsm, which is necessary for messages like this, which do not seem like "what's new" messages and do not use the What's New panel, but nonetheless share much of the underlying code.

Flags: needinfo?(edilee)

The protections panel message is still being shown, and that's what caused the delay / comments in the original patch https://phabricator.services.mozilla.com/D122009#3966384 as it wasn't clear if it needed to still be shown or safe to remove.

Seems like we'll probably need to dig into some metrics of people seeing it and clicking learn more. I suppose if it does want to be kept around, the code specific to this protections panel message could be moved into where it gets inserted:
https://searchfox.org/mozilla-central/rev/4cc23dcad1142ec79256f449a55460215fc75498/browser/base/content/browser-siteProtections.js#1665

Flags: needinfo?(edilee)
Iteration: 110.2 - Dec 26 - Jan 6 → 110.3 - Jan 9 - Jan 13
Iteration: 110.3 - Jan 9 - Jan 13 → 111.1 - Jan 16 - Jan 27
Iteration: 111.1 - Jan 16 - Jan 27 → 111.2 - Jan 30 - Feb 10
You need to log in before you can comment on or make changes to this bug.