1863041 - Camera capture limited to built-in cameras on macOS

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This was introduced in 120 in the libwebrtc update.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1857862

Comment 2

[Ryan VanderMeulen [:RyanVM]]

(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #0)

This was introduced in 120 in the libwebrtc update.

The linked regressed by bug was for the update that landed for 121. Did you mean to use bug 1851693?

Comment 3

[Andreas Pehrson [:pehrsons]]

He meant 121. This is the only candidate commit.

Comment 4

[Andreas Pehrson [:pehrsons]]

[Tracking Requested - why for this release]: external webcams not usable on MacOS.

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

(In reply to Andreas Pehrson [:pehrsons] from comment #3)

He meant 121. This is the only candidate commit.

This reproduces with ./mach mozregression --launch 120.

pehrsons, yeah, I had found that hunk and modified it to include external camera types:

+ (NSArray<AVCaptureDevice*>*)captureDevices {
  AVCaptureDeviceDiscoverySession* session = [AVCaptureDeviceDiscoverySession
      discoverySessionWithDeviceTypes:@[
        AVCaptureDeviceTypeBuiltInWideAngleCamera,
        AVCaptureDeviceTypeExternalUnknown
      ]
                            mediaType:AVMediaTypeVideo
                             position:AVCaptureDevicePositionUnspecified];
  return session.devices;
}

That does populate the gUM prompt correctly, however, we no longer get frames.

Comment 6

[Andreas Pehrson [:pehrsons]]

Is there a permissions problem perhaps? It works fine for me in 120b8 (dev edition).

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

(In reply to Andreas Pehrson [:pehrsons] from comment #6)

Is there a permissions problem perhaps? It works fine for me in 120b8 (dev edition).
Ah, ./mach mozregression --launch FIREFOX_120_0b6_RELEASE --repo mozilla-beta works.
./mach mozregression --launch 120 launches 121.0a1...

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1863041 - P1 - allow access to more than just built-in cameras on macOS;r?pehrsons

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1863041 - P0 - add device filter control to RTCCameraVideoCapturer;r?pehrsons

I have filed this bug upstream: https://bugs.chromium.org/p/webrtc/issues/detail?id=15639
Edit: here is the upstream review request https://webrtc-review.googlesource.com/c/src/+/327367/1

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/504805344eef
P1 - allow access to more than just built-in cameras on macOS;r=pehrsons,webrtc-reviewers

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on device_info_avfoundation.mm

Backout link: https://hg.mozilla.org/integration/autoland/rev/ff86054371b742a9cea65b9480bab9a352ec1113
Log link: https://treeherder.mozilla.org/logviewer?job_id=436397301&repo=autoland&lineNumber=17612

Comment 13

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The parent-child relationship between P0 and P1 was not set in Phabricator, so only P1 landed. This is likely because I created P1 first and later rebased it onto P0.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a763d768b7
P0 - add device filter control to RTCCameraVideoCapturer;r=pehrsons,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/eb78feb610e5
P1 - allow access to more than just built-in cameras on macOS;r=pehrsons,webrtc-reviewers

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/91a763d768b7
https://hg.mozilla.org/mozilla-central/rev/eb78feb610e5

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/91a763d768b7
https://hg.mozilla.org/mozilla-central/rev/eb78feb610e5

Comment 18

[Simona Badau, Desktop QA]

Reproduced the initial issue on Nightly 121.0a1 (Build ID: 20231109123600).

Verified as fixed on Firefox 120.0b7 and on the latest Nightly 122.0a1 - camera capture is no longer limited to built-in cameras. I tested by requesting camera permissions on https://permission.site/ using a Microsoft LifeCam HD-3000 camera on a macOS 13 MacBook.