1863126 - Remove implementation-specific code from ParseISOStyleDate

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[Vinny Diehl]

As discussed here, it would be best to limit the scope of ParseISOStyleDate to spec behavior:
https://tc39.es/ecma262/#sec-date-time-string-format

After D192671 lands, that function will continue to support formats which are not to-spec:

• YYYY-MM-DD HH:mm:ss.sssZ (space instead of 'T')
• YYYY-MM-DD H:m:s.sssZ (above, with single-digit hour|minute|second)

With the addition of TryParseDashedNumericDatePrefix in bug 1557650, as well as support for 'Z' timezone specifier in bug 1852422, we are getting close to being able to refactor this function to only support spec behavior.

I started working on this but ran up against bug 1863125, we'll need to look at that first. I'll upload a WIP patch for now.

Comment 1

[Vinny Diehl]

Attachment: Bug 1863126 - Refactor ParseISOStyleDate to remove implementation-specific code r?arai

The implementation-specific parsing for these types of dates is now
covered by TryParseDashedNumericDatePrefix, so we can do away with
this isStrict/isPermissive business now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de7ca4a4e862
Refactor ParseISOStyleDate to remove implementation-specific code r=arai

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/de7ca4a4e862