1863403 - Cards View: consider styling of Group by Sort headers

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Elizabeth Mitchell]

Consider Group by Sort styling and improve styling where possible.

At a minimum, make the (#/#) more understandable.

Though for technical reasons we cannot change having 3 rows, we can make the headers look better overall.

+++ This bug was initially created as a clone of Bug #1861853 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

Enable card view and group by sort in the message view.

Actual results:

Group headers have the same height as messages (which was recently increased to three lines).

Expected results:

Group headers should be reduced to a single line to reflect the fact that they only contain a signle line of text.

This does not affect touch navigation because the only clickable element in the group header is the arrow button.

Comment 1

[Elizabeth Mitchell]

Attachment: WIP: Bug 1863403 - Use updated twisty button for Grouped by Sort.

Comment 2

[Elizabeth Mitchell]

We need to consider design on this first before implementation.

I'll take a look at the work in progress patch to see where this left off. Update: I've updated the patch with an image.

Comment 3

[[e-mail]]

It looks like the dummy rows generated for the Group by Sort headers are done in the c++. If possible it would be nice to pass this off to js and use a template for easier styling and structure edits.

Comment 4

[[e-mail]]

Attachment: WIP: Bug 1863403: [Cards View] Style Group by Sort headers.

Comment 5

[Geoff Lankow (:darktrojan) [OOO, back 21 July]]

I thought we'd got somewhere on this, sorry if I've been the one holding it up.

You can get the unread and total counts by adding unreadCol to this list, totalCol is already there. The values turn up as cellTexts here and propertiesSet will contain "dummy" if you need to detect dummy rows in the JS.

If you're displaying the counts differently you can trash the block from nsMsgGroupView::CellTextForColumn that adds the values to the subject line in brackets.

On a related note, the "replies" icon briefly shows up next to the twisty in these headers, then disappears. That probably should be fixed.

Comment 6

[[e-mail]]

Attachment: Bug 1863403: [Cards View] Style Group by Sort headers. r=#thunderbird-front-end-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f985a698d474
[Cards View] Style Group by Sort headers. r=vineet

Comment 8

[[e-mail]]

Attachment: Bug 1863403: follow up to fix browser_columns.js test not knowing about unreadCol. r=#thunderbird-front-end-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8508aeba95d
follow up to fix browser_columns.js test not knowing about unreadCol. r=vineet

Comment 10

[Martin Giger [:freaktechnik]]

This sometimes triggers the warning [fluent-dom] An element named "threadpane-sort-header-unread-count" wasn't found in the source. - I think when we previously showed a string that didn't use that element? I only noticed this after running TB, so I'm not sure if it has actual visual impact - but I fear it might.