1863797 - Frequent dom/security/test/https-first/browser_schemeless.js - UrlbarView.selectedElement may become invalid

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=435485883&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LO4Az9iTSIuQbhKMKLN38w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-11-08T19:02:30.182Z] 19:02:30     INFO - TEST-PASS | dom/security/test/https-first/browser_schemeless.js | New tab test: Should not upgrade upgradeable website with explicit scheme - 
[task 2023-11-08T19:02:30.183Z] 19:02:30     INFO - Buffered messages logged at 18:47:56
[task 2023-11-08T19:02:30.183Z] 19:02:30     INFO - Waiting for the urlbar view to open
[task 2023-11-08T19:02:30.184Z] 19:02:30     INFO - Urlbar view opened
[task 2023-11-08T19:02:30.186Z] 19:02:30     INFO - Buffered messages logged at 18:48:56
[task 2023-11-08T19:02:30.187Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 9
[task 2023-11-08T19:02:30.187Z] 19:02:30     INFO - Buffered messages logged at 18:50:26
[task 2023-11-08T19:02:30.188Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 8
[task 2023-11-08T19:02:30.189Z] 19:02:30     INFO - Buffered messages logged at 18:51:59
[task 2023-11-08T19:02:30.190Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 7
[task 2023-11-08T19:02:30.195Z] 19:02:30     INFO - Buffered messages logged at 18:53:29
[task 2023-11-08T19:02:30.196Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 6
[task 2023-11-08T19:02:30.196Z] 19:02:30     INFO - Buffered messages logged at 18:54:59
[task 2023-11-08T19:02:30.197Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 5
[task 2023-11-08T19:02:30.197Z] 19:02:30     INFO - Buffered messages logged at 18:56:29
[task 2023-11-08T19:02:30.198Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 4
[task 2023-11-08T19:02:30.199Z] 19:02:30     INFO - Buffered messages logged at 18:57:59
[task 2023-11-08T19:02:30.199Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 3
[task 2023-11-08T19:02:30.200Z] 19:02:30     INFO - Buffered messages logged at 18:59:29
[task 2023-11-08T19:02:30.201Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2023-11-08T19:02:30.201Z] 19:02:30     INFO - Buffered messages logged at 19:00:59
[task 2023-11-08T19:02:30.202Z] 19:02:30     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2023-11-08T19:02:30.202Z] 19:02:30     INFO - Buffered messages finished
[task 2023-11-08T19:02:30.203Z] 19:02:30     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/https-first/browser_schemeless.js | Test timed out - 
[task 2023-11-08T19:02:30.204Z] 19:02:30     INFO - GECKO(13927) | MEMORY STAT | vsize 20975781MB | residentFast 1446MB
[task 2023-11-08T19:02:30.205Z] 19:02:30     INFO - TEST-OK | dom/security/test/https-first/browser_schemeless.js | took 905016ms
[task 2023-11-08T19:02:30.206Z] 19:02:30     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-08T19:02:30.206Z] 19:02:30     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/https-first/browser_schemeless.js | Found a tab after previous test timed out: about:about - 
[task 2023-11-08T19:02:30.207Z] 19:02:30     INFO - checking window state
[task 2023-11-08T19:02:30.208Z] 19:02:30     INFO - TEST-START | dom/security/test/https-first/browser_slow_download.js

Comment 1

[Intermittent Failures Robot]

2 failures in 3288 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform and build breakdown:

• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-06&endday=2023-11-12&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812192

Comment 3

[Intermittent Failures Robot]

18 failures in 738 pushes (0.024 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• mozilla-central: 7
• try: 2

Platform and build breakdown:

• linux1804-64-qr: 13
  • debug: 11
  • opt: 2
• linux1804-64-asan-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-15&endday=2023-11-15&tree=all

Comment 4

[Intermittent Failures Robot]

15 failures in 610 pushes (0.025 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 5
• autoland: 8
• try: 2

Platform and build breakdown:

• linux1804-64-qr: 12
  • debug: 9
  • opt: 3
• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-17&endday=2023-11-17&tree=all

Comment 5

[Natalia Csoregi [:nataliaCs]]

Update

There have been 55 total failures within the last 7 days:

• 11 failures on Linux 18.04 x64 WebRender asan opt
• 39 failures on Linux 18.04 x64 WebRender debug/opt
• 5 failures on Linux 18.04 x64 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=436773062&repo=autoland&lineNumber=57138

Comment 6

[Intermittent Failures Robot]

62 failures in 3495 pushes (0.018 failures/push) were associated with this bug in the last 7 days.

This is the #20 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 35
• mozilla-central: 21
• try: 6

Platform and build breakdown:

• linux1804-64-asan-qr: 14
  • opt: 14
• linux1804-64-qr: 42
  • debug: 34
  • opt: 8
• linux1804-64-shippable-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-13&endday=2023-11-19&tree=all

Comment 7

[Intermittent Failures Robot]

23 failures in 816 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• try: 3
• mozilla-central: 4
• mozilla-beta: 3

Platform and build breakdown:

• linux1804-64-qr: 11
  • debug: 10
  • opt: 1
• linux1804-64-asan-qr: 8
  • opt: 8
• linux1804-64-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-20&endday=2023-11-20&tree=all

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812192

Comment 9

[Intermittent Failures Robot]

17 failures in 799 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• mozilla-central: 4
• mozilla-beta: 3
• try: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 6
  • opt: 6
• linux1804-64-qr: 9
  • debug: 9
• linux1804-64-shippable-qr: 1
  • opt: 1
• windows11-64-2009-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-21&endday=2023-11-21&tree=all

Comment 10

[Intermittent Failures Robot]

24 failures in 741 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• mozilla-central: 4
• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 5
  • opt: 5
• linux1804-64-qr: 15
  • debug: 12
  • opt: 3
• linux1804-64-asan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-22&endday=2023-11-22&tree=all

Comment 11

[Intermittent Failures Robot]

21 failures in 615 pushes (0.034 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 1
• autoland: 11
• mozilla-central: 6
• mozilla-beta: 3

Platform and build breakdown:

• linux1804-64-qr: 14
  • debug: 11
  • opt: 3
• linux1804-64-asan-qr: 5
  • opt: 5
• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-23&endday=2023-11-23&tree=all

Comment 12

[Intermittent Failures Robot]

30 failures in 457 pushes (0.066 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• mozilla-central: 8
• autoland: 13
• mozilla-beta: 3
• try: 6

Platform and build breakdown:

• linux1804-64-qr: 15
  • debug: 10
  • opt: 5
• linux1804-64-asan-qr: 8
  • opt: 8
• linux1804-64-shippable-qr: 6
  • opt: 6
• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-24&endday=2023-11-24&tree=all

Comment 13

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1863797 - Disable browser_schemeless.js on linux fore frequent failures. r=#intermittent-reviewers,freddyb

Comment 14

[Cosmin Sabou [:CosminS]]

This became frequent after the changes in Bug 1852442 - backfills here.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b55181dd063c
Disable browser_schemeless.js on linux for frequent failures. r=jmaher

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b55181dd063c

Comment 17

[Intermittent Failures Robot]

121 failures in 3623 pushes (0.033 failures/push) were associated with this bug in the last 7 days.

This is the #5 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 68
• try: 11
• mozilla-central: 27
• mozilla-beta: 15

Platform and build breakdown:

• linux1804-64-qr: 70
  • debug: 57
  • opt: 13
• linux1804-64-asan-qr: 31
  • opt: 31
• linux1804-64-shippable-qr: 18
  • opt: 18
• windows11-64-2009-asan-qr: 1
  • opt: 1
• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-20&endday=2023-11-26&tree=all

Comment 18

[Dale Harvey (:daleharvey)]

Ok taking a look, almost every failure I can see in the log starts with

[task 2023-11-17T22:23:59.301Z] 22:23:59     INFO - TEST-PASS | dom/security/test/https-first/browser_schemeless.js | Main test: Should not upgrade upgradeable website without explicit scheme - 
[task 2023-11-17T22:23:59.301Z] 22:23:59     INFO - Waiting for the urlbar view to open
[task 2023-11-17T22:23:59.302Z] 22:23:59     INFO - Urlbar view opened
[task 2023-11-17T22:23:59.302Z] 22:23:59     INFO - Buffered messages logged at 22:10:26
[task 2023-11-17T22:23:59.303Z] 22:23:59     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 9
[task 2023-11-17T22:23:59.303Z] 22:23:59     INFO - Buffered messages logged at 22:11:58
[task 2023-11-17T22:23:59.304Z] 22:23:59     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 8

Which seems relevant

Comment 19

[Intermittent Failures Robot]

32 failures in 4108 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 26
• try: 3
• autoland: 3

Platform and build breakdown:

• linux1804-64-qr: 8
  • debug: 8
• linux1804-64-shippable-qr: 4
  • opt: 4
• windows11-64-2009-qr: 1
  • debug: 1
• windows11-64-2009-asan-qr: 6
  • opt: 6
• linux1804-64-asan-qr: 11
  • opt: 11
• linux1804-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-11-27&endday=2023-12-03&tree=all

Comment 20

[Malte Jürgens [:maltejur]]

Attachment: Bug 1863797 - Fix intermittent dom/security/test/https-first/browser_schemeless.js r?mak,daleharvey

Comment 22

[Marco Bonardo [:mak]]

Attachment: Bug 1863797 - Frequent failures in browser_schemeless.js due to UrlbarView.selectedElement removed from DOM. r=adw

#selectedElement may end up pointing to disconnected nodes. And so the public
.selectedElement getter.
In the specific failure here, a first call to onQueryResults adds and selects a
heuristic result. Then a second call to onQueryResults brings a new heuristic
result that requires new content (not compatible with the previous one), so the
old heuristic is emptied out, and new DOM is generated.
Because the code in onQueryResults relies on .selectedElement, at the second
invokation it thinks the selection is still valid. In reality .selectedElement
at that time is pointing to a removed DOM node.
The patch changes the public getters, that is also what onQueryResults uses.

Plus some minor logging improvement, and removing unused #mainContainer property.

Comment 23

[Intermittent Failures Robot]

28 failures in 3671 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 26
• try: 1
• autoland: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 13
  • opt: 13
• linux1804-64-qr: 13
  • debug: 13
• windows11-64-2009-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-12-04&endday=2023-12-10&tree=all

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f45306a093
Frequent failures in browser_schemeless.js due to UrlbarView.selectedElement removed from DOM. r=adw

Comment 25

[Marco Bonardo [:mak]]

I don't think this fix can be easily verified by QA due to requiring a very specific situation and timing. The added automated test should be sufficient.

Comment 26

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/12f45306a093

Comment 27

[Intermittent Failures Robot]

7 failures in 4224 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2
• autoland: 2
• mozilla-release: 3

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1
• windows11-64-2009-asan-qr: 2
  • opt: 2
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-12-11&endday=2023-12-17&tree=all

Comment 28

[Intermittent Failures Robot]

2 failures in 3349 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-12-18&endday=2023-12-24&tree=all

Comment 29

[Intermittent Failures Robot]

1 failures in 1162 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2023-12-25&endday=2023-12-31&tree=all

Comment 30

[Intermittent Failures Robot]

2 failures in 2274 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2024-01-01&endday=2024-01-07&tree=all

Comment 31

[Intermittent Failures Robot]

2 failures in 3217 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2024-01-08&endday=2024-01-14&tree=all

Comment 32

[Intermittent Failures Robot]

1 failures in 3799 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1863797&startday=2024-07-15&endday=2024-07-21&tree=all