Closed Bug 1863813 Opened 1 year ago Closed 1 year ago

[Easy Setup Feature] - Remove unused assets and strings

Categories

(Firefox :: Messaging System, task, P2)

Product:
Firefox
Component:
Messaging System
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Iteration:
123.3 - Jan 15 - Jan 19
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: nsauermann, Assigned: nsauermann)

References

Details

(Whiteboard: [omc])

Attachments

(1 file, 1 obsolete file)

Bug 1863813 - [Easy Setup Feature] - Remove unused strings
48 bytes, text/x-phabricator-request
Details | Review

With the release of 1855031, several screens in onboarding are no longer used and assets and fluent string ids can be removed.

Assignee: nobody → nsauermann
Iteration: --- → 122.1 - Nov 20 - Dec 1
Points: --- → 2
Priority: -- → P1
Status: NEW → ASSIGNED
Whiteboard: [omc]
Iteration: 122.1 - Nov 20 - Dec 1 → 122.2 - Dec 4 - Dec 15

Reprioritized as a P2 until work involved in 1863400 is wrapped up.

Priority: P1 → P2
Iteration: 122.2 - Dec 4 - Dec 15 → 123.1 - Dec 18 - Dec 29
Iteration: 123.1 - Dec 18 - Dec 29 → 123.2 - Jan 1 - Jan 12

Synced up with Punam - since PIN/DEFAULT assets/strings are reused in upgrade dialog (https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#138 and https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#464) this bug will be repurposed as potentially removing upgrade dialogue which is currently disable on nimbus.

NI'ing product to check if there's any plans on re-introduce upgrade dialogue in the near future or if it's safe to remove.

Flags: needinfo?(vtay)
Flags: needinfo?(nbulous)

There are no current plans to re-introduce the upgrade dialogue. Even if we do, we'll likely just be using the components of the upgrade dialogue and not the assets and strings, so they are safe to remove.

Flags: needinfo?(vtay)
Flags: needinfo?(nbulous)
Summary: [Easy Setup Feature] - Remove unused assets and strings → [Easy Setup Feature] - Cleanup unused assets/strings and remove upgrade dialog
Points: 2 → 3
Summary: [Easy Setup Feature] - Cleanup unused assets/strings and remove upgrade dialog → [Easy Setup Feature] - Remove upgrade dialog
Attachment #9373051 - Attachment description: Bug 1863813 - [Easy Setup Feature] - Removes upgrade dialog and unused string ids → WIP: Bug 1863813 - [Easy Setup Feature] - Removes upgrade dialog and unused string ids
Iteration: 123.2 - Jan 1 - Jan 12 → 123.3 - Jan 15 - Jan 19
Summary: [Easy Setup Feature] - Remove upgrade dialog → [Easy Setup Feature] - Remove unused upgrade dialog messages, assets
Attachment #9373051 - Attachment is obsolete: true
Summary: [Easy Setup Feature] - Remove unused upgrade dialog messages, assets → [Easy Setup Feature] - Remove unused assets and strings
Attachment #9373270 - Attachment description: Bug 1863813 - [Easy Setup Feature] - Remove unused assets and strings" → Bug 1863813 - [Easy Setup Feature] - Remove unused assets and strings
Attachment #9373270 - Attachment description: Bug 1863813 - [Easy Setup Feature] - Remove unused assets and strings → Bug 1863813 - [Easy Setup Feature] - Remove unused assets and strings"
Attachment #9373270 - Attachment description: Bug 1863813 - [Easy Setup Feature] - Remove unused assets and strings" → Bug 1863813 - [Easy Setup Feature] - Remove unused strings
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/256d1bfb66e3 [Easy Setup Feature] - Remove unused strings r=omc-reviewers,emcminn

https://hg.mozilla.org/mozilla-central/rev/256d1bfb66e3

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: